From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Bastien Guerry <bzg@altern.org>
Cc: emacs-devel@gnu.org
Subject: Re: Handle empty regexp in `rmail-nonignored-headers'
Date: Sun, 10 Feb 2008 14:34:42 -0500 [thread overview]
Message-ID: <jwvwspcfvx6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87tzkgix8h.fsf@bzg.ath.cx> (Bastien Guerry's message of "Sun, 10 Feb 2008 16:37:18 +0000")
> The default value for `rmail-nonignored-headers' is "^x-spam-status:".
> If the user wants to remove this header from the list of non-ignored
> headers, she will set `rmail-nonignored-headers' to the empty string.
> This will end up in *not* ignoring any header, which is wrong.
> This simple patch fixed this -- can I commit it?
I'd rather allow rmail-nonignored-headers to be nil (to mean "don't
unignore any headers") and let "" have its standard meaning of "match
everything/everywhere".
Stefan
> --- rmail.el.~1.447.~ 2008-02-06 23:54:33.000000000 +0000
> +++ rmail.el 2008-02-10 16:30:56.000000000 +0000
> @@ -2329,7 +2329,8 @@
> (while (and ignored-headers
> (re-search-forward ignored-headers nil t))
> (beginning-of-line)
> - (if (looking-at rmail-nonignored-headers)
> + (if (and (not (equal rmail-nonignored-headers ""))
> + (looking-at rmail-nonignored-headers))
> (forward-line 1)
> (delete-region (point)
> (save-excursion
> --
> Bastien
next prev parent reply other threads:[~2008-02-10 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 16:37 Handle empty regexp in `rmail-nonignored-headers' Bastien Guerry
2008-02-10 19:34 ` Stefan Monnier [this message]
2008-02-10 22:25 ` Bastien
2008-02-10 20:03 ` Eli Zaretskii
2008-02-11 0:17 ` Richard Stallman
2008-02-11 1:01 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwspcfvx6.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bzg@altern.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.