23.0.60; c-mode advices font-lock-after-change-function?

23.0.60; c-mode advices font-lock-after-change-function?

[Lennart Borgman (gmail)]

It looks like c-mode advices font-lock-after-change-function. To see this do

   emacs -Q
   ;; move to *scratch* buffer
   C-h f font-lock-after-change-function
   M-x c-mode
   C-h f font-lock-after-change-function



In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
  of 2008-03-21
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags 
-Ic:/g/include -fno-crossjumping'

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: nil
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: ENU
   value of $XMODIFIERS: nil
   locale-coding-system: cp1252
   default-enable-multibyte-characters: t

Major mode: C/l

Minor modes in effect:
   tooltip-mode: t
   tool-bar-mode: t
   mouse-wheel-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   global-auto-composition-mode: t
   auto-composition-mode: t
   auto-compression-mode: t
   line-number-mode: t
   abbrev-mode: t

Re: 23.0.60; c-mode advices font-lock-after-change-function?

[Stefan Monnier]

> It looks like c-mode advices font-lock-after-change-function. To see this do

Indeed, see http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=13


        Stefan

Re: 23.0.60; c-mode advices font-lock-after-change-function?

[Richard Stallman]

    It looks like c-mode advices font-lock-after-change-function. To see this do

       emacs -Q
       ;; move to *scratch* buffer
       C-h f font-lock-after-change-function
       M-x c-mode
       C-h f font-lock-after-change-function

It is not a good thing for parts of Emacs to advise other parts.
What is the reason for this?

Re: 23.0.60; c-mode advices font-lock-after-change-function?

[Alan Mackenzie]

Hi, Lennart and Stefan,

On Sat, Mar 22, 2008 at 12:32:21PM -0400, Stefan Monnier wrote:
> > It looks like c-mode advices font-lock-after-change-function.

It does.  However, it needn't, at least not in Emacs >= 22.  The right
thing seems to be font-lock-extend-after-change-region-function here.
I'll get it done soon, well before Emacs 22.3.

[A point of English usage, Lennart:  "advice" is a noun; the
corresponding verb is "to advise".]

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: 23.0.60; c-mode advices font-lock-after-change-function?

[Stefan Monnier]

>> > It looks like c-mode advices font-lock-after-change-function.

> It does.  However, it needn't, at least not in Emacs >= 22.  The right
> thing seems to be font-lock-extend-after-change-region-function here.
> I'll get it done soon, well before Emacs 22.3.

Thank you,


        Stefan

Re: 23.0.60; c-mode advices font-lock-after-change-function?

[Alan Mackenzie]

Hi, Stefan

On Sat, Mar 22, 2008 at 08:38:13PM -0400, Stefan Monnier wrote:
> >> > It looks like c-mode advices font-lock-after-change-function.

> > It does.  However, it needn't, at least not in Emacs >= 22.  The right
> > thing seems to be font-lock-extend-after-change-region-function here.
> > I'll get it done soon, well before Emacs 22.3.

DONE, both in the Emacs 22 branch and the trunk.

> Thank you,

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).