From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: breadcrumbs for Info . . . . . . Date: Fri, 13 Jun 2008 18:44:10 -0400 Message-ID: References: <009d01c8cb55$13d53e20$0200a8c0@us.oracle.com> <87fxrkltma.fsf@jurta.org> <00ae01c8cb71$c26aeef0$0200a8c0@us.oracle.com> <873ankqou6.fsf@jurta.org> <00d901c8cbc9$7df36fb0$0200a8c0@us.oracle.com> <87tzfzk331.fsf@jurta.org> <00a501c8ccdd$93328720$c2b22382@us.oracle.com> <002401c8cd1f$98631650$0200a8c0@us.oracle.com> <004a01c8cd67$b2f7a9c0$0200a8c0@us.oracle.com> <00b101c8cda2$63175a50$0200a8c0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1213414930 4448 80.91.229.12 (14 Jun 2008 03:42:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Jun 2008 03:42:10 +0000 (UTC) Cc: 'Juri Linkov' , emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 14 05:42:53 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K7MfE-0007sM-7p for ged-emacs-devel@m.gmane.org; Sat, 14 Jun 2008 05:42:52 +0200 Original-Received: from localhost ([127.0.0.1]:59453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7MeQ-0005gp-FW for ged-emacs-devel@m.gmane.org; Fri, 13 Jun 2008 23:42:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7Mdu-0005Uk-HR for emacs-devel@gnu.org; Fri, 13 Jun 2008 23:41:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7Mds-0005U3-Mt for emacs-devel@gnu.org; Fri, 13 Jun 2008 23:41:30 -0400 Original-Received: from [199.232.76.173] (port=33055 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7Mds-0005Ty-J1 for emacs-devel@gnu.org; Fri, 13 Jun 2008 23:41:28 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:29465 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K7Mds-00081L-78 for emacs-devel@gnu.org; Fri, 13 Jun 2008 23:41:28 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlAFAG7aUkjO+KWv/2dsb2JhbABBgRqsAA X-IronPort-AV: E=Sophos;i="4.27,642,1204520400"; d="scan'208";a="22510416" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 13 Jun 2008 23:41:26 -0400 Original-Received: from ceviche.home ([206.248.165.175]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id UJD55426 for ; Fri, 13 Jun 2008 23:41:26 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id AFAD3B4087; Fri, 13 Jun 2008 18:44:10 -0400 (EDT) In-Reply-To: <00b101c8cda2$63175a50$0200a8c0@us.oracle.com> (Drew Adams's message of "Fri, 13 Jun 2008 15:11:10 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99163 Archived-At: > . I generally like the replacement of File: and Node: by > including that info in the breadcrumbs - bonne initiative. > On the other hand (some food for thought): > - The current node could be omitted from the crumbs, to save > space, since it is already present in (a) the mode-line and > (b) the node title. I decided to keep the information that was there before. I.e. the "file" info (merged into the "Top" node), and the current node. > - If the file+top link is moved back to the header-line, more > space is saved. In that case, it should be made into a (top) > link. (I thought it already was a link, but I see now that > that is in my own code). It is the breadcrumbs line where > space is critical; it is likely to be longer than the > header-line. The file is also listed in the mode-line. In my tests (and with my setup), the header-line already tends to overflow more than the breadcrumbs, so I don't want to move more stuff over there. > - Moving current and file+top to the header-line would probably > eliminate any need for the depth option (except to turn off). I introduced the depth first and foremost to ensure termination. > . When using ellipsis, I suggest dropping first the current > node name and the file+top - precisely the parts you keep. I keep them precisely because they were there before. > . The `>' appears even at the beginning: "> (dir)Top". That is Yes, it seemed like a good idea. I'd be happy to change it. > . The doc string of `Info-breadcrumbs-depth' should explain > that it refers to the number of ancestor nodes, i.e., that it The number of nodes actually displayed depends on too many things: to be really precise, the docstring would need to be overly complex. It's not like people will get confused anyway: the user can try a value and then increase/decrease it. > . You might want to bind `Info-fontify-maximum-menu-size' to > nil, as I did, for the calls to `Info-goto-node'. That will > save useless extra fontification. You misread the code. > . So much for the time I spent shortening lines. You reverted > to the original lengths, which includes lines up to 137 chars > wide. No problem, but please don't bother to ask for that again. Yes, I only asked you to shorten your own code, not the rest. Stefan