From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#865: 23.0.60; The directory is unsafe today Date: Fri, 05 Sep 2008 09:16:51 -0400 Message-ID: References: <48BD642C.5050405@gmail.com> <48BD74D5.4050800@gnu.org> <48BDD155.8060005@gnu.org> <48BF2171.8040101@gnu.org> <48BF5671.1040705@gnu.org> Reply-To: Stefan Monnier , 865@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1220621274 8454 80.91.229.12 (5 Sep 2008 13:27:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Sep 2008 13:27:54 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, 865@emacsbugs.donarmstrong.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 05 15:28:47 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KbbMk-0007Ub-U4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Sep 2008 15:28:47 +0200 Original-Received: from localhost ([127.0.0.1]:41303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KbbLl-00037j-Dq for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Sep 2008 09:27:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KbbLc-00032J-Ps for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2008 09:27:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KbbLb-00031I-TR for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2008 09:27:36 -0400 Original-Received: from [199.232.76.173] (port=33262 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KbbLb-000310-09 for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2008 09:27:35 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:60451) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KbbLb-0005bi-BL for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2008 09:27:35 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m85DRVpV008676; Fri, 5 Sep 2008 06:27:31 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m85DPCHo007947; Fri, 5 Sep 2008 06:25:13 -0700 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 05 Sep 2008 13:25:12 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 865 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 865-submit@emacsbugs.donarmstrong.com id=B865.12206206275159 (code B ref 865); Fri, 05 Sep 2008 13:25:12 +0000 Original-Received: (at 865) by emacsbugs.donarmstrong.com; 5 Sep 2008 13:17:07 +0000 Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m85DGwa9005146 for <865@emacsbugs.donarmstrong.com>; Fri, 5 Sep 2008 06:17:02 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAHjNwEhFxJRU/2dsb2JhbACBZbU2gWWBBg X-IronPort-AV: E=Sophos;i="4.32,320,1217822400"; d="scan'208";a="26389525" Original-Received: from 69-196-148-84.dsl.teksavvy.com (HELO pastel.home) ([69.196.148.84]) by ironport2-out.teksavvy.com with ESMTP; 05 Sep 2008 09:16:52 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 595718398; Fri, 5 Sep 2008 09:16:51 -0400 (EDT) In-Reply-To: (Eli Zaretskii's message of "Fri, 05 Sep 2008 13:52:44 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Fri, 05 Sep 2008 09:27:36 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20195 gmane.emacs.pretest.bugs:22983 Archived-At: >> I think the problem comes earlier: the (let ((default-file-modes ?\700)) >> should make sure that the directory created there is owned by the use >> and not by some Administator group. > That's a different problem. I don't see how it can be solved without > introducing a new primitive, which on Windows will DTRT. (I think > GNU/Linux and Unix systems that support ACLs will need a similar > primitive, but I don't know enough about those to say for sure.) > There are a few other places in Emacs other than server.el that make > similar tests, for reasons other than making sure the file/directory > is private to the current user. Here's the list: > files.el:file-ownership-preserved-p > eshell/em-ls.el:eshell-ls-applicable > net/ange-ftp.el:ange-ftp-parse-netrc > (the last one is actually quite similar to server.el). I think we need to consider the testing part and the file (or dir) creation part separately. And my previous messages pointed out that the core problem (securitywise) is in the creation part, which is hence unrelated to the above 3 other cases. >> Of course, on FAT there's just nothing we can do and the >> server-ensure-safe-dir functionality simply cannot be provided, so we >> should then just skip the safety checks, > On FAT, all files belong to a user called Everyone, who has a special > UID of 0, so I think all these checks will simply pass, or at least > they should. No, they shouldn't, since the tests are meant to ensure that only the current user has write access, whereas FAT cannot provide this behavior. Stefan