From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Inconsistency in `string-to-number' Date: Fri, 24 Apr 2009 10:06:42 -0400 Message-ID: References: <47083.128.165.123.18.1240532205.squirrel@webmail.lanl.gov> <833abygwxo.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1240582383 1264 80.91.229.12 (24 Apr 2009 14:13:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Apr 2009 14:13:03 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 24 16:14:22 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LxM4q-0002lh-8V for ged-emacs-devel@m.gmane.org; Fri, 24 Apr 2009 16:08:28 +0200 Original-Received: from localhost ([127.0.0.1]:43277 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LxM3R-0007XO-5T for ged-emacs-devel@m.gmane.org; Fri, 24 Apr 2009 10:07:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LxM3L-0007Vy-Vk for emacs-devel@gnu.org; Fri, 24 Apr 2009 10:06:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LxM3H-0007Px-Ce for emacs-devel@gnu.org; Fri, 24 Apr 2009 10:06:55 -0400 Original-Received: from [199.232.76.173] (port=39325 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LxM3G-0007Pi-SV for emacs-devel@gnu.org; Fri, 24 Apr 2009 10:06:51 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:7363 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LxM39-0000uO-MO; Fri, 24 Apr 2009 10:06:43 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQFAK9j8UlMCrUB/2dsb2JhbACBUM9zg3QFhS4 X-IronPort-AV: E=Sophos;i="4.40,241,1238990400"; d="scan'208";a="37553341" Original-Received: from 76-10-181-1.dsl.teksavvy.com (HELO pastel.home) ([76.10.181.1]) by ironport2-out.teksavvy.com with ESMTP; 24 Apr 2009 10:06:42 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 23A017EFE; Fri, 24 Apr 2009 10:06:42 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Fri, 24 Apr 2009 15:38:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110462 Archived-At: >> Except that it will break existing code. > I know, as I explicitly acknowledged that fact in my message... > Also, it was Eli who suggested it. Don't take it personally, I was just pointing out the part which I found to be most important. I know I have written code which relies on this behavior (tho I can't remember where ... hmm ... probably there's some of it in diff-mode.el). > Still, that code relies in undocumented behavior. As the "1:" vs. > "1.2:" vs. "1.2" difference demonstrates, it's just luck that > it works. No doubt this is a bug. It's a long-standing one, tho, so it's not a regression in Emacs-23. Eli said: > Which is why I thing we should fix it the other way around: to > recognize "1.2:" as a number. That cannot possibly break anything, so > it should be safe to do before the release, IMO. Actually it could also break code (tho it seems unlikely). I wouldn't mind postponing the fix to Emacs-23.2. In the mean time, we need to improve the docstring. Stefan