all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Inconsistency in `string-to-number'
Date: Fri, 24 Apr 2009 10:06:42 -0400	[thread overview]
Message-ID: <jwvws9axiab.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f7ccd24b0904240638k7841310eoc952f795581b448e@mail.gmail.com> (Juanma Barranquero's message of "Fri, 24 Apr 2009 15:38:17 +0200")

>> Except that it will break existing code.
> <sigh> I know, as I explicitly acknowledged that fact in my message...
> Also, it was Eli who suggested it.

Don't take it personally, I was just pointing out the part which I found
to be most important.  I know I have written code which relies on this
behavior (tho I can't remember where ... hmm ... probably there's some
of it in diff-mode.el).

> Still, that code relies in undocumented behavior.  As the "1:" vs.
> "1.2:" vs. "1.2" difference demonstrates, it's just luck that
> it works.

No doubt this is a bug.  It's a long-standing one, tho, so it's not
a regression in Emacs-23.

Eli said:
> Which is why I thing we should fix it the other way around: to
> recognize "1.2:" as a number.  That cannot possibly break anything, so
> it should be safe to do before the release, IMO.

Actually it could also break code (tho it seems unlikely).  I wouldn't
mind postponing the fix to Emacs-23.2.  In the mean time, we need to
improve the docstring.


        Stefan




  reply	other threads:[~2009-04-24 14:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24  0:16 Inconsistency in `string-to-number' Davis Herring
2009-04-24 10:36 ` Eli Zaretskii
2009-04-24 11:45   ` Juanma Barranquero
2009-04-24 13:19     ` Eli Zaretskii
2009-04-24 14:13       ` Juanma Barranquero
2009-04-24 13:22     ` Stefan Monnier
2009-04-24 13:38       ` Juanma Barranquero
2009-04-24 14:06         ` Stefan Monnier [this message]
2009-04-24 14:16           ` Juanma Barranquero
2009-09-05  0:30           ` Juanma Barranquero
2009-12-01 20:15             ` Stefan Monnier
2009-12-04  3:21               ` Juanma Barranquero
2009-12-04  3:23                 ` Juanma Barranquero
2009-12-04 14:22                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvws9axiab.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.