From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Bastien <bastienguerry@googlemail.com>
Cc: emacs-devel@gnu.org
Subject: Re: save-frame-excursion?
Date: Mon, 27 Jul 2009 22:25:13 -0400 [thread overview]
Message-ID: <jwvws5td022.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87my6p9254.fsf@bzg.ath.cx> (Bastien's message of "Tue, 28 Jul 2009 05:05:16 +0800")
>>> This patch makes sure that `make-frame' gives the focus back to the
>>> previously selected frame.
>>> Shall I apply this?
>> Don't know. Here are some comments:
>> - does it work (as in "with Metacity/W32/macosx/xmonad/addyourfavoriteWMhere")?
> I don't have access to all these WM, I'm sending the patch here to get
> feedback about this.
I know, I just wanted to make it explicit, assuming other people are
following this as well.
>> - it's not clear that it does the right thing if the selected-frame
>> is not the frame with focus (basically we'd need a focussed-frame
>> function to figure it out).
> Yes, a focused-frame would be nice.
Please at least add a FIXME comment about it, and post a bug-report to
track this issue.
>> - it brings us back to this problem of "focus via activation".
>> - is x-focus-frame always defined when this code is run (i.e. can't
>> this code be run also on emacs-nox)?
> So maybe a variant of this patch should better be applied to
> make-frame-command, which handle this distinction between x/nox.
No, lower-level is better, but you may just want to wrap the call with
an (if (fboundp 'focus-frame) ...) or someting like that. Or maybe
implement it at an even lower level (like x-create-frame).
>> - x-focus-frame should really be renamed (so as to get rid of the "x-"
>> prefix at least).
> Okay. I can't do the job about renaming x-focus-frame and creating the
> focused-frame function so I guess my fix will wait for that.
In any case we need to test it first. We may get away with using
selected-frame rather than focused-frame: maybe it doesn't make that
much of a difference in practice.
Stefan
next prev parent reply other threads:[~2009-07-28 2:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 17:30 save-frame-excursion? Bastien
2009-07-23 20:56 ` save-frame-excursion? Stefan Monnier
2009-07-24 2:24 ` save-frame-excursion? Robert Goldman
2009-07-24 3:16 ` save-frame-excursion? Stefan Monnier
2009-07-24 3:28 ` save-frame-excursion? Robert Goldman
2009-07-24 19:24 ` save-frame-excursion? Stefan Monnier
2009-07-24 21:18 ` save-frame-excursion? Robert Goldman
2009-07-25 14:39 ` save-frame-excursion? Stefan Monnier
2009-07-25 11:42 ` save-frame-excursion? Bastien
2009-07-25 14:42 ` save-frame-excursion? Stefan Monnier
2009-07-25 22:11 ` save-frame-excursion? Bastien
2009-07-26 14:26 ` save-frame-excursion? Stefan Monnier
2009-07-26 17:00 ` save-frame-excursion? Drew Adams
2009-07-27 3:42 ` save-frame-excursion? Bastien
2009-07-27 4:50 ` save-frame-excursion? Stephen J. Turnbull
2009-07-27 4:58 ` save-frame-excursion? Bastien
2009-07-27 17:49 ` save-frame-excursion? Stefan Monnier
2009-07-27 21:05 ` save-frame-excursion? Bastien
2009-07-28 2:25 ` Stefan Monnier [this message]
[not found] ` <87iqhhasm3.fsf@bzg.ath.cx>
2009-08-03 4:38 ` save-frame-excursion? Carsten Dominik
2009-08-03 12:50 ` save-frame-excursion? Robert Goldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvws5td022.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bastienguerry@googlemail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.