From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#5481: 23.1; insert-kbd-macro: does not write key-binding code Date: Wed, 03 Mar 2010 15:13:49 -0500 Message-ID: References: <2f987f0d1001260935j6af42c95oad99250fec836326@mail.gmail.com> <2f987f0d1003030632x7176f6e0ke4a568837268de23@mail.gmail.com> <87635ds7zw.fsf@stupidchicken.com> <2f987f0d1003030820v7ddc620dub9a8ee1ef86e88d8@mail.gmail.com> <87ocj5tiny.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1267647939 26452 80.91.229.12 (3 Mar 2010 20:25:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 3 Mar 2010 20:25:39 +0000 (UTC) Cc: 5481@debbugs.gnu.org, Dani Moncayo To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 03 21:25:34 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nmv8P-000560-2m for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Mar 2010 21:25:33 +0100 Original-Received: from localhost ([127.0.0.1]:38492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nmv8O-0004Yp-GQ for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Mar 2010 15:25:32 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nmv70-00036P-PT for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2010 15:24:06 -0500 Original-Received: from [140.186.70.92] (port=36611 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nmv6z-000348-6V for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2010 15:24:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nmv6y-00016k-Cp for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2010 15:24:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43854) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nmv6x-00016f-Ki for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2010 15:24:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NmuyE-0002uy-FX; Wed, 03 Mar 2010 15:15:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Mar 2010 20:15:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5481 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5481-submit@debbugs.gnu.org id=B5481.126764724711194 (code B ref 5481); Wed, 03 Mar 2010 20:15:02 +0000 Original-Received: (at 5481) by debbugs.gnu.org; 3 Mar 2010 20:14:07 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NmuxL-0002uV-80 for submit@debbugs.gnu.org; Wed, 03 Mar 2010 15:14:07 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nmux8-0002u8-Rm for 5481@debbugs.gnu.org; Wed, 03 Mar 2010 15:14:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAF5RjkvO+JkM/2dsb2JhbACbC3S+A4R8BIMXh3E X-IronPort-AV: E=Sophos;i="4.49,575,1262581200"; d="scan'208";a="57430199" Original-Received: from 206-248-153-12.dsl.teksavvy.com (HELO pastel.home) ([206.248.153.12]) by ironport2-out.pppoe.ca with ESMTP; 03 Mar 2010 15:13:50 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id DB5C18205; Wed, 3 Mar 2010 15:13:49 -0500 (EST) In-Reply-To: <87ocj5tiny.fsf@stupidchicken.com> (Chong Yidong's message of "Wed, 03 Mar 2010 12:32:49 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 03 Mar 2010 15:15:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:35407 Archived-At: > I see the problem. On further examination, there was already code in > macro.el that was supposed to handle this, but it was broken. I've > checked in a fix. Thanks for the bug report, and for the follow-up. [...] > * src/keymap.c (Fwhere_is_internal): Use Fequal to compare > definitions, so that keyboard macros are correctly handled > (Bug#5481). Could you explain why Fequal is necessary there? It should only make a difference if we're comparing one macro (ie. vector) against another identical macro, but IIUC that shouldn't be the case here. Stefan