From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Tim Van Holder <tim.vanholder@gmail.com>
Cc: 7215@debbugs.gnu.org
Subject: bug#7215: 24.0.50; Minibuffer path completion mispositions point
Date: Sun, 17 Oct 2010 13:31:34 -0400 [thread overview]
Message-ID: <jwvwrpgzpz8.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87aamgc3jr.fsf@leeloo.anubex.internal> (Tim Van Holder's message of "Thu, 14 Oct 2010 15:22:16 +0200")
> Now delete most of "directory", leaving the minibuffer as:
> Find file: .../dir*/subdir/
> Now press [tab]. This correctly completes "dir" back to "directory", but
> also moves point backwards, resulting in:
> Find file: .../di*rectory/subdir/
I've installed the patch below into the emacs-23 branch. This should
fix the problem. Please confirm,
Stefan
=== modified file 'lisp/minibuffer.el'
--- lisp/minibuffer.el 2010-10-03 19:50:14 +0000
+++ lisp/minibuffer.el 2010-10-17 17:26:12 +0000
@@ -498,10 +498,11 @@
(setq suffix-len (1+ suffix-len)))
(unless (zerop suffix-len)
(setq end (- end suffix-len))
- (setq newtext (substring newtext 0 (- suffix-len)))))
+ (setq newtext (substring newtext 0 (- suffix-len))))
(goto-char beg)
(insert newtext)
- (delete-region (point) (+ (point) (- end beg))))
+ (delete-region (point) (+ (point) (- end beg)))
+ (forward-char suffix-len)))
(defun completion--do-completion (&optional try-completion-function)
"Do the completion and return a summary of what happened.
next prev parent reply other threads:[~2010-10-17 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 13:22 bug#7215: 24.0.50; Minibuffer path completion mispositions point Tim Van Holder
2010-10-15 14:08 ` Stephen Berman
2010-10-17 17:31 ` Stefan Monnier [this message]
2010-10-18 6:56 ` Tim Van Holder
2010-10-18 14:24 ` Stefan Monnier
2010-10-18 20:03 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwrpgzpz8.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=7215@debbugs.gnu.org \
--cc=tim.vanholder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.