From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#7292: view-mode clobbers speedbar bindings Date: Fri, 29 Oct 2010 12:00:30 -0400 Message-ID: References: <4CC8BDBE.4090709@gmail.com> <7lr5fbuiji.fsf@fencepost.gnu.org> <4CC8E9E9.8080104@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1288368807 21608 80.91.229.12 (29 Oct 2010 16:13:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 29 Oct 2010 16:13:27 +0000 (UTC) Cc: 7292@debbugs.gnu.org, Ryan Twitchell To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 29 18:13:23 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PBrZx-0000AA-Rq for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Oct 2010 18:13:22 +0200 Original-Received: from localhost ([127.0.0.1]:49453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBrZx-0003T2-1N for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Oct 2010 12:13:21 -0400 Original-Received: from [140.186.70.92] (port=39344 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBrZm-0003Os-QD for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2010 12:13:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBrZl-0004s5-Fx for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2010 12:13:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBrZl-0004ru-Cw for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2010 12:13:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PBrKA-0004XN-A9; Fri, 29 Oct 2010 11:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Oct 2010 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7292 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7292-submit@debbugs.gnu.org id=B7292.128836780117429 (code B ref 7292); Fri, 29 Oct 2010 15:57:02 +0000 Original-Received: (at 7292) by debbugs.gnu.org; 29 Oct 2010 15:56:41 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PBrJp-0004X4-0h for submit@debbugs.gnu.org; Fri, 29 Oct 2010 11:56:41 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PBrJm-0004Wx-Ql for 7292@debbugs.gnu.org; Fri, 29 Oct 2010 11:56:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgwKABSNykzO+Krc/2dsb2JhbACgVn1yvyiFSASSKg X-IronPort-AV: E=Sophos;i="4.58,260,1286164800"; d="scan'208";a="81043638" Original-Received: from 206-248-170-220.dsl.teksavvy.com (HELO ceviche.home) ([206.248.170.220]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 29 Oct 2010 12:00:30 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 7B919660F5; Fri, 29 Oct 2010 12:00:30 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Fri, 29 Oct 2010 03:49:29 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 29 Oct 2010 11:57:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41230 Archived-At: >>> (I notice a few other files call toggle-read-only as well. Seems odd.) >> A fair question. I suppose this is just caution: toggle-read-only will >> always "do the right thing" to make sure the buffer is read-only, though >> setting buffer-read-only should be sufficient. > That doesn't make sense to me. I replace several inappropriate uses, > including the speedbar one. > I wonder if toggle-read-only should even be added to > byte-compile-interactive-only-functions. I wonder as well. I know I'm to blame for some of the calls to toggle-read-only, because I thought it might be better to use the higher-level function. But indeed it seems that was a mistake. So let's add it to byte-compile-interactive-only-functions (with a comment about why); and if it turns out that there are many cases where calling it from Elisp makes sense, then we'll get to learn which are the cases where it makes sense. Stefan