all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: emacs-devel@gnu.org
Subject: Re: Async DNS lookups
Date: Thu, 04 Nov 2010 10:15:45 -0400	[thread overview]
Message-ID: <jwvwrotw5l4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m31v71pk78.fsf@hase.home> (Andreas Schwab's message of "Thu, 04 Nov 2010 09:27:39 +0100")

>>>> I think the implication is that you would have to add one (and use it
>>>> every time any code whatsoever accessed that variable).
>>> It's already being used several places without any locking.
>> Indeed, because it's only accessed by a single thread right now (it's
>> not even accessed from a signal handler).  So you'd have to add locking
>> if it becomes shared between threads.
> Since it is using Lisp values it cannot be used by anything but the main
> thread anyway.

It's true that the other thread can't do things like call Fcons (before
the allocation code is not synchronized either), but the other thread can
still perform an assignment to a Lisp_Object variable, as long as that
variable is properly synchronized.

So you just have to ensure that the allocation of the pending_funcalls
element is done before forking the new thread.
I.e. when the name resolution is over, the other thread will want to do
something like:

   lock(pending_funcalls);
   setcar(result, pending_funcalls);
   pending_funcalls = result;
   unlock(pending_funcalls);

Of course, that leaves open the problem of how to translate the non-Lisp
result into Lisp_Objects.

I.e. you'll probably want to use some new variable, very similar to
pending_funcalls, but for "pending_c_funcalls" so that the pending calls
can first do some C preprocessing to turn the C result data into Lisp data
and then call the Elisp callback.


        Stefan



  reply	other threads:[~2010-11-04 14:15 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-30 11:57 Async DNS lookups Lars Magne Ingebrigtsen
2010-10-30 13:11 ` Julien Danjou
2010-10-30 13:34 ` Ted Zlatanov
2010-10-30 15:40 ` Helmut Eller
2010-10-31  4:01 ` Stefan Monnier
2010-10-31 17:16   ` Lars Magne Ingebrigtsen
2010-11-01 16:09 ` Tom Tromey
2010-11-02 16:15   ` Ken Raeburn
2010-11-02 16:29     ` Lars Magne Ingebrigtsen
2010-11-02 17:28       ` Stefan Monnier
2010-11-02 18:13         ` Lars Magne Ingebrigtsen
2010-11-02 18:30           ` Tom Tromey
2010-11-02 18:28             ` Lars Magne Ingebrigtsen
2010-11-02 18:47               ` Tom Tromey
2010-11-02 21:28           ` Stefan Monnier
2010-11-03 19:46             ` Lars Magne Ingebrigtsen
2010-11-03 21:29               ` Davis Herring
2010-11-03 21:46                 ` Lars Magne Ingebrigtsen
2010-11-04  2:24                   ` Stefan Monnier
2010-11-04  8:27                     ` Andreas Schwab
2010-11-04 14:15                       ` Stefan Monnier [this message]
2010-11-04 16:09                         ` Ken Raeburn
2010-11-04 19:49                         ` Lars Magne Ingebrigtsen
2010-11-04 20:40                         ` Davis Herring
2010-11-04 21:32                           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwrotw5l4.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.