all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alexander Klimov <alserkli@inbox.ru>
Cc: emacs-devel@gnu.org
Subject: Re: patch for completion in octave
Date: Mon, 25 Apr 2011 13:32:47 -0300	[thread overview]
Message-ID: <jwvwriixpjo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <TheMailAgent.755e20e1b5b814@32293d178731f9c1c8d30> (Alexander Klimov's message of "Wed, 9 Feb 2011 16:00:23 +0200")

>> So, could you try the patch below instead for a little while and see if
>> it fixes your problem (it should) and if it doesn't introduce
>> other issues?

> Your patch is also a good idea since it removes a code duplication,
> but besides fixing the original problem, it evinces that we have

>     (modify-syntax-entry ?. "w"   table)
>     (modify-syntax-entry ?_ "w"   table)

> in octave-mod.el, that makes M-f or M-b on something like

I've installed a patch which should fix this, along with the poriginal
completion problem in octave-inf.

> In the menu "Lookup Octave Index" does not work since info-lookup-mode
> is not set (maybe we should set lookup mode "globally" instead and
> remove octave-help?).

I've set info-lookup-mode in inferior-actave-mode indeed, so that the
standard binding for info-lookup-symbol (C-h S) works.

> There is also a problem with completion-addsuffix, since `v<Tab>'
> gives `var ' and now the user has to press DEL to continue with
> `.field' (btw, since the structure completion is possible, I added `.'
> into the skip pattern below).

The new code does not use comint's comint-dynamic-simple-complete but
also gets rid of the addsuffix.  This may not always be the right thing
to do (it's sometimes convenient to have the SPC suffix), but until we
can determine when it's good and when it's not, I'd rather not add any.


        Stefan



      reply	other threads:[~2011-04-25 16:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 12:49 patch for completion in octave Alexander Klimov
2011-02-08 20:39 ` Stefan Monnier
2011-02-09 14:00   ` Alexander Klimov
2011-04-25 16:32     ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwriixpjo.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=alserkli@inbox.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.