From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: 8613@debbugs.gnu.org
Subject: bug#8613: "mode:" for minor-mode breaks set-visited-file-name
Date: Mon, 09 May 2011 19:44:46 -0300 [thread overview]
Message-ID: <jwvwrhza4aj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <3gk4dzo7h6.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 09 May 2011 18:05:25 -0400")
>> (string-match "-mode\\'" (symbol-name (car form))))))
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Does not compute.
Not sure why it wouldn't compute, but I'll trust you on that one.
> Anyway, that would work, tho' perhaps it could just be hard-coded in
> hack-one-local-variable-eval-safep, since the safety of mode: is not
> customizable at present, and having hooks with non-empty defaults is
> sub-optimal.
Agreed. As mentioned recently, I'm fine with a non-nil hook as long as
it's preloaded and not defcustom. But I think safe-local-eval-functions
would be a likely defcustom, so it should be nil.
> The only reason I could see needing :safe as an argument was if someone
> had some hypothetical minor-mode that for some reason was not safe. In
> which case, passing ":safe nil" seems like the simplest thing to me,
> rather than eg ":safe 'no", or inverting the whole thing to use :risky
> instead of :safe.
I prefer :risky. It's always handy to be able to do things like
:foo (plist-get <bar> :foo), so ":foo nil" should behave the same as
its absence.
> But, there's no option to do this with mode:, so this is not needed to
> replace mode: for minor-modes.
Agreed. If/when we need it we can add a :risky. In the mean time if
someone really needs it she can add a (put 'mode
'safe-local-eval-function nil) after the define-minor-mode.
Stefan
next prev parent reply other threads:[~2011-05-09 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 23:00 bug#8613: "mode:" for minor-mode breaks set-visited-file-name Glenn Morris
2011-05-04 0:38 ` Stefan Monnier
2011-05-04 2:08 ` Glenn Morris
2011-05-04 12:52 ` Stefan Monnier
2011-05-05 2:20 ` Glenn Morris
2011-05-05 12:40 ` Stefan Monnier
2011-05-09 22:05 ` Glenn Morris
2011-05-09 22:44 ` Stefan Monnier [this message]
2011-05-09 23:41 ` Glenn Morris
2011-05-10 1:09 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwrhza4aj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=8613@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.