From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Štěpán Němec" <stepnem@gmail.com>
Cc: 8897@debbugs.gnu.org
Subject: bug#8897: `completion--insert-strings' clobbers user-added text properties
Date: Mon, 20 Jun 2011 10:01:22 -0400 [thread overview]
Message-ID: <jwvwrggk3m3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y60x9b8y.fsf@gmail.com> ("Štěpán Němec"'s message of "Mon, 20 Jun 2011 10:07:41 +0200")
>>> In my particular case I define annotations as buttons (which display
>>> even more detail about a completion value upon activation), so a visual
>>> indication of clickability is very important for me.
>> Currently, the completion-list-mode uses the `mouse-face' text-property
>> to determine what is a completion item and what i something else (blank
>> space, annotation, you name it). So as it stands, any mouse-face you'd
>> add to an annotation would confuse completion-list-mode into thinking it
>> is a completion item.
>> Maybe you could try to use the `category' text-property instead.
> Well I do use the `category' property, but the button functions seem to
> set up the button face automatically, which is then clobbered by
> `completion--insert-strings' (which is the problem). Here's how I set up
> an annotation, `n' being the number of a pull request as a string (i.e.,
> the completion value itself):
> #+begin_src elisp
> (let ((req (assoc-default n minibuffer-completion-table)))
> (concat " "
> (propertize (plist-get req :title)
> 'fontified t
> 'button '(t)
> 'category 'default-button
> 'help-echo "RET or mouse-2 for details"
> 'pr-data req
> 'action (lambda (b) (magithub-pull-request-details
> (button-get b 'pr-data))))))
> #+end_src
I must be missing something: where is a `face' or `mouse-face' property
added? The above code should not be affected by your patch, AFAICT.
And I don't understand your comment about "but the button functions seem
to set up the button face automatically" since I don't see where you
call a button function before insertion.
> With my patch I haven't noticed any problems you mention -- clicking
> or RET on the completion itself selects it, clicking or RET on the
> annotation displays further details, the button face is preserved.
I guess click&RET work OK because they're locally overridden, but if you
run M-x choose-completion while on the button or if you hit `left' or
`right' to skip from one completion to the next, you might see some
problem (although not with the code quoted above which should not
suffer from any of the problems discussed in this thread, AFAICT).
Stefan
next prev parent reply other threads:[~2011-06-20 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 18:22 bug#8897: `completion--insert-strings' clobbers user-added text properties Štěpán Němec
2011-06-19 18:34 ` Glenn Morris
2011-06-20 3:08 ` Stefan Monnier
2011-06-20 8:07 ` Štěpán Němec
2011-06-20 14:01 ` Stefan Monnier [this message]
2011-06-20 14:22 ` Štěpán Němec
2011-06-20 16:36 ` Stefan Monnier
2020-09-14 12:25 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwrggk3m3.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=8897@debbugs.gnu.org \
--cc=stepnem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.