From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#9639: 24.0.90; Problem with bury-buffer in minibuffer-hide-completions Date: Sat, 01 Oct 2011 20:38:33 -0400 Message-ID: References: <87hb3thebv.fsf@escher.home> <4E86D879.7060105@gmx.at> <87r52xkp0l.fsf@escher.home> <4E86F22B.5060007@gmx.at> <4E874831.3060709@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1317515938 13053 80.91.229.12 (2 Oct 2011 00:38:58 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 2 Oct 2011 00:38:58 +0000 (UTC) Cc: 9639@debbugs.gnu.org, Stephen Berman To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 02 02:38:54 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RAA4z-0007nR-GL for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Oct 2011 02:38:53 +0200 Original-Received: from localhost ([::1]:56745 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAA4z-0005G2-0N for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2011 20:38:53 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:33701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAA4x-0005Fx-0c for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2011 20:38:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RAA4v-0006t3-OF for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2011 20:38:50 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAA4v-0006sz-Mk for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2011 20:38:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RAA67-0006U3-6M for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2011 20:40:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2011 00:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9639-submit@debbugs.gnu.org id=B9639.131751599324904 (code B ref 9639); Sun, 02 Oct 2011 00:40:02 +0000 Original-Received: (at 9639) by debbugs.gnu.org; 2 Oct 2011 00:39:53 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAA5w-0006Td-FL for submit@debbugs.gnu.org; Sat, 01 Oct 2011 20:39:53 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RAA5t-0006TU-4V for 9639@debbugs.gnu.org; Sat, 01 Oct 2011 20:39:49 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAMmxh05FpZLc/2dsb2JhbABBqDWBBoFTAQEEAVYjBQsLNBIUGA0kiA63FYckBKB5hEM X-IronPort-AV: E=Sophos;i="4.68,475,1312171200"; d="scan'208";a="139567162" Original-Received: from 69-165-146-220.dsl.teksavvy.com (HELO pastel.home) ([69.165.146.220]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 01 Oct 2011 20:38:34 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B736E59291; Sat, 1 Oct 2011 20:38:33 -0400 (EDT) In-Reply-To: <4E874831.3060709@gmx.at> (martin rudalics's message of "Sat, 01 Oct 2011 19:04:49 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 01 Oct 2011 20:40:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:52057 Archived-At: >> BTW, can't we just use `quit-window'? > This would delete a stand-alone frame and not iconify it. That's a problem of quit-window. I know that some users like this behavior, but making the distinction based on whether the code happened to use quit-window instead of bury-buffer is wrong, IMO. Both bury-buffer and quit-window should hide dedicated frames in the same way, either both by iconifying, or both by deleting the frame (and they should share the same code to do it). This shared code can provide a hook to let the user choose how the frame gets hidden, but the default should be to iconify since that's how it's worked until now (and also because I think it's a safer default, in the sense that iconifying throws away less information than deleting the frame). >> But of course, if we can get the *Completions* window/frame deleted >> without marking it as dedicated, that'd be fine as well. > We could give `quit-window' a third argument telling it to iconify the > frame instead of deleting it or add an option to deal with this case. An argument doesn't seem right, since the choice doesn't depend on the caller, AFAIK, but on the user. > Since I still intend to eventually replace window excursions by > `display-buffer' + `quit-window' (which will probably take years) some > general pattern would be useful anyway. Yes, we agree on this overarching goal, tho I think the issue is not so much save-window-excursion (which generally needs to be solved by changing the code so it doesn't call display-buffer at all) but rather "stash current-window-configuration + set-window-configuration". Stefan