From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10022: 24.0.91; `isearch-mouse-2' relies on `x-get-selection' - NG for Windows etc. Date: Fri, 18 Nov 2011 14:13:07 -0500 Message-ID: References: <055102FB22B94F7E8A0B265429BF6E09@us.oracle.com> <8D45DB2157F84E788061E93D188B14FE@us.oracle.com> <80F2D45C3F624FCC918B30031333293C@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1321643664 21259 80.91.229.12 (18 Nov 2011 19:14:24 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2011 19:14:24 +0000 (UTC) Cc: 10022-done@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 18 20:14:19 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RRTtD-0004GB-Eg for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2011 20:14:19 +0100 Original-Received: from localhost ([::1]:58798 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRTtC-0003J3-UT for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2011 14:14:18 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:58900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRTt7-0003I8-AV for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 14:14:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRTt3-0007b7-Ea for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 14:14:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRTt3-0007QF-D5 for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 14:14:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RRTtu-0003Cv-2T for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 14:15:02 -0500 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2011 19:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 10022 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 10022@debbugs.gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by 10022-done@debbugs.gnu.org id=D10022.132164365112247 (code D ref 10022); Fri, 18 Nov 2011 19:15:01 +0000 Original-Received: (at 10022-done) by debbugs.gnu.org; 18 Nov 2011 19:14:11 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRTt3-0003BT-Rr for submit@debbugs.gnu.org; Fri, 18 Nov 2011 14:14:11 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRTt0-0003BI-R7 for 10022-done@debbugs.gnu.org; Fri, 18 Nov 2011 14:14:08 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAICtxk5FpZVk/2dsb2JhbABDqjSBBoFyAQEEAVYjBQsLNBIUGA0QARMTiAO3AooXBIgXmXeESg X-IronPort-AV: E=Sophos;i="4.69,534,1315195200"; d="scan'208";a="148510961" Original-Received: from 69-165-149-100.dsl.teksavvy.com (HELO pastel.home) ([69.165.149.100]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 18 Nov 2011 14:13:07 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 7F3DD5936A; Fri, 18 Nov 2011 14:13:07 -0500 (EST) In-Reply-To: (Drew Adams's message of "Fri, 18 Nov 2011 10:02:52 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 18 Nov 2011 14:15:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54047 Archived-At: >> To the extent that isearch only binds mouse-2 in the minibuffer (yes, >> it technically also binds it in the main buffer, but to a command that >> just delegates to the normal binding), I don't think >> down-mouse-2 should default to `ignore', except maybe in the minibuffer. > What I meant was that a nil binding means pick up any currently > effective (e.g. global) binding. If someone binds `down-mouse-2' > globally (as I do) then that binding will be picked for Isearch also, > and it might not be appropriate there. But as I point out, the mouse-2 binding also runs the global binding (tho indirectly, and except when in the minibuffer area), so running the global binding of down-mouse-2 seems like the right thing to do. >> so it really doesn't seem like a bug for it to fail when there is >> no GUI selection > The bug would presumably be that `x-get-selection' returns nil here, ?? What should it return if there's no GUI selection? > Agreed. There is no change needed for vanilla Emacs 24. OK, thanks. > The only changes I have made are (a) for a non-nil option > `isearchp-mouse-2-flag' (yank the non-empty region) As mentioned on gnu.emacs.help (which may not have gotten to help-gnu-emacs@gnu.org :-( ), users should already be able to get such behavior with (define-key isearch-mode-map [mouse-2] 'isearch-yank-x-selection) but this wouldn't override select-active-region (which is a separate issue, although your isearchp-mouse-2-flag controls both). Stefan