From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] window.el: Improve mark management Date: Fri, 20 Jan 2012 08:42:50 -0500 Message-ID: References: <87zkdjtr4v.fsf@Apollo.jerryland.fr> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1327066990 26108 80.91.229.12 (20 Jan 2012 13:43:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 20 Jan 2012 13:43:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?iso-8859-1?Q?J=E9r=E9my?= Compostella Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 20 14:43:06 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RoEkD-0002Xo-SX for ged-emacs-devel@m.gmane.org; Fri, 20 Jan 2012 14:43:06 +0100 Original-Received: from localhost ([::1]:34249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoEkD-0004hX-G8 for ged-emacs-devel@m.gmane.org; Fri, 20 Jan 2012 08:43:05 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:35453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoEk6-0004hG-BH for emacs-devel@gnu.org; Fri, 20 Jan 2012 08:43:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RoEk0-0008A7-HU for emacs-devel@gnu.org; Fri, 20 Jan 2012 08:42:58 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:47890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoEk0-00089y-DZ for emacs-devel@gnu.org; Fri, 20 Jan 2012 08:42:52 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAOBuGU9MCos2/2dsb2JhbABDrX+BBoFyAQEEAVYjBQsLLQcSFBgNJIgPuGmIfoMoBIg8mnCEVg X-IronPort-AV: E=Sophos;i="4.71,542,1320642000"; d="scan'208";a="157766255" Original-Received: from 76-10-139-54.dsl.teksavvy.com (HELO pastel.home) ([76.10.139.54]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Jan 2012 08:42:50 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 484055946E; Fri, 20 Jan 2012 08:42:50 -0500 (EST) In-Reply-To: <87zkdjtr4v.fsf@Apollo.jerryland.fr> (=?iso-8859-1?Q?=22J=E9r?= =?iso-8859-1?Q?=E9my?= Compostella"'s message of "Thu, 19 Jan 2012 20:43:28 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147769 Archived-At: > into account the previously set mark(s). It looks better to use > `push-mark' instead of `set-mark'. Moreover it does not restore the > active mark state which lead to an automatically active mark in > restored buffer. `push-mark' is wrong if nothing happened between window-state-get and window-state-put. And the mark & mark-active are buffer-local but not window-local. If we window-state-get in a frame which shows the same buffer several times, window-state-put would end up pushing the same mark several times. Stefan