From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: toggle-read-only should not give compilation warnings Date: Sun, 15 Jul 2012 18:01:44 -0400 Message-ID: References: <877gubszqq.fsf@gnu.org> <87txxcgrq2.fsf@gnu.org> <87obnjai2i.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1342389714 11647 80.91.229.3 (15 Jul 2012 22:01:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 15 Jul 2012 22:01:54 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 16 00:01:54 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SqWsy-00012e-90 for ged-emacs-devel@m.gmane.org; Mon, 16 Jul 2012 00:01:52 +0200 Original-Received: from localhost ([::1]:53066 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqWsx-00087C-KL for ged-emacs-devel@m.gmane.org; Sun, 15 Jul 2012 18:01:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqWsv-00086v-5m for emacs-devel@gnu.org; Sun, 15 Jul 2012 18:01:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqWsu-0004Ga-6S for emacs-devel@gnu.org; Sun, 15 Jul 2012 18:01:49 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:34733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqWsu-0004GW-2J; Sun, 15 Jul 2012 18:01:48 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q6FM1jAG030747; Sun, 15 Jul 2012 18:01:46 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id CBA28AE323; Sun, 15 Jul 2012 18:01:44 -0400 (EDT) In-Reply-To: <87obnjai2i.fsf@gnu.org> (Chong Yidong's message of "Fri, 13 Jul 2012 21:47:49 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4280=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4280> : streams <785141> : uri <1166194> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151639 Archived-At: >> Once we're sure that the remaining calls to toggle-read-only are all >> "correct", we should try to understand why that is and provide some >> alternative function for that (and make toggle-read-only use that >> function, of course). > It's not difficult to see why the remaining calls are correct: they want > to do the same thing as C-x C-q, either acting on a different buffer or > with a different interactive invocation. Examples include > mode-line-toggle-read-only and Buffer-menu-toggle-read-only. > Adding another function, rather than simply using toggle-read-only, is > an unnecessary level of indirection. Even better. Stefan