From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: David Engster <deng@randomsample.de>
Cc: 11916@debbugs.gnu.org
Subject: bug#11916: 24.1.50; Making url-dav work
Date: Wed, 25 Jul 2012 20:04:22 -0400 [thread overview]
Message-ID: <jwvwr1rbdhv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87r4rz8sck.fsf@engster.org> (David Engster's message of "Wed, 25 Jul 2012 23:04:59 +0200")
> Anyway, it's a very seldom used feature, so I just implemented what you
> suggested.
Not quite. See below.
> (defun xml-parse-tag-1 (&optional parse-dtd parse-ns)
> "Like `xml-parse-tag', but possibly modify the buffer while working."
> - (let ((xml-validating-parser (or parse-dtd xml-validating-parser))
> - (xml-ns (cond ((consp parse-ns) parse-ns)
> - (parse-ns xml-default-ns))))
> + (let* ((xml-validating-parser (or parse-dtd xml-validating-parser))
> + (symbol-qnames
> + (when (or (eq parse-ns 'symbol-qnames)
> + (eq (car-safe parse-ns) 'symbol-qnames))
> + 'symbol-qnames))
> + (xml-ns
> + (cond ((symbolp (car-safe parse-ns))
> + (or (cdr-safe parse-ns)
> + xml-default-ns))
> + ((consp parse-ns) parse-ns)
> + (parse-ns xml-default-ns))))
No, no, don't add a symbol-qnames variable here, use the same
representation I proposed for xml-ns instead. And similarly don't add
any argument to xml-maybe-do-ns. This should result in a patch that
touches very little code (just the computation of xml-ns above and its
use in xml-maybe-do-ns, and not much else).
Stefan
next prev parent reply other threads:[~2012-07-26 0:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 21:00 bug#11916: 24.1.50; Making url-dav work David Engster
2012-07-18 12:25 ` Stefan Monnier
2012-07-18 17:45 ` David Engster
2012-07-19 7:15 ` Stefan Monnier
2012-07-19 15:28 ` David Engster
2012-07-19 22:12 ` Stefan Monnier
2012-07-21 12:11 ` David Engster
2012-07-22 10:11 ` Stefan Monnier
2012-07-25 21:04 ` David Engster
2012-07-26 0:04 ` Stefan Monnier [this message]
2012-07-26 16:01 ` David Engster
2012-07-26 23:32 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwr1rbdhv.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=11916@debbugs.gnu.org \
--cc=deng@randomsample.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.