From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] POSIX ACL support Date: Tue, 20 Nov 2012 13:15:10 -0500 Message-ID: References: <878v9yr1h1.fsf@silenus.orebokech.com> <87ehjpp9b7.fsf@silenus.orebokech.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1353435328 20891 80.91.229.3 (20 Nov 2012 18:15:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 Nov 2012 18:15:28 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Romain Francoise Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 20 19:15:39 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TasMD-0008DP-MP for ged-emacs-devel@m.gmane.org; Tue, 20 Nov 2012 19:15:37 +0100 Original-Received: from localhost ([::1]:36140 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TasM3-0006wf-BB for ged-emacs-devel@m.gmane.org; Tue, 20 Nov 2012 13:15:27 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TasLy-0006wJ-5F for emacs-devel@gnu.org; Tue, 20 Nov 2012 13:15:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TasLs-0000i8-40 for emacs-devel@gnu.org; Tue, 20 Nov 2012 13:15:22 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:37054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TasLr-0000hM-O5; Tue, 20 Nov 2012 13:15:16 -0500 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id qAKIFAau009471; Tue, 20 Nov 2012 13:15:10 -0500 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 53B86B4278; Tue, 20 Nov 2012 13:15:10 -0500 (EST) In-Reply-To: <87ehjpp9b7.fsf@silenus.orebokech.com> (Romain Francoise's message of "Mon, 19 Nov 2012 22:33:16 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4408=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4408> : streams <862298> : uri <1272913> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154994 Archived-At: > However, I think Glenn was also referring to the additional argument to > `copy-file', which doesn't preserve the modes. Yes, this also needs to be handled in a similar way (tho I'm not sure what you mean by "which doesn't preserve the modes" since the docstring says "This function always sets the file modes of the output file to match the input file."). > But maybe we can change the existing `preserve-selinux-context' > argument into a more general `preserve-platform-attributes' argument > and do both ACL and SELinux? Any caller that wants to preserve the > SELinux context probably wants to preserve the ACL entries as > well, anyway. Actually, I'd go even further and merge PRESERVE-UID-GID PRESERVE-SELINUX-CONTEXT into a single argument. > Ideally we'd get rid of `file-modes', `file-selinux-context' and > `file-posix-acl' and just add the info to `file-attributes', which already > returns a list of 12 different attributes. Then `set-file-attributes' > would be created to set all those different attributes in one go. But that > would be a lot of work... I'm not sure I'm ready to add the info to file-attributes. But we could start by providing a new file-extended-attributes which returns a self-descriptive list of attributes, and then set-file-extended-attributes which takes that list and applies it. Stefan