all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Barry OReilly <gundaetiapo@gmail.com>,
	15045@debbugs.gnu.org, deng@randomsample.de,
	eric@siege-engine.com
Subject: bug#15045: Point jumps inappropriately around time of Semantic lexing
Date: Tue, 15 Oct 2013 09:42:03 -0400	[thread overview]
Message-ID: <jwvwqlen052.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83ppr7pr6c.fsf@gnu.org>

> FWIW, I'm against such changes.  You can never know how many places
> will be subtly broken by changes like that in such a popular
> interface.

Hmm... I kind of agree with both:
- this is a subtle change affecting behavior in a corner case and it's
  difficult to know which code might care about it.
- nothing in input-pending-p indicates this is some kind of
  blocking/waiting operation which might hence correspond to a "yield
  point".  On the contrary, the intuition behind input-pending-p would
  make you think that the whole point of it is to let you find out if
  there's input *without waiting*.

So I tend to agree with Barry that input-pending-p should not run
timers.  Not just based on his particular problem case, but on the basis
of what ideally input-pending-p should do.

Arguably it shouldn't process_special_events either, tho obviously,
removing this call would introduce a known breakage, so we should keep
this for now (until we have a better fix for it).
  
> The original problem is rare enough, and should IMO be fixed in the
> code where it happens.

It can be difficult to "fix" it there, because there's simply no other
operation that lets you detect if there's input in the queue without
running arbitrary code, so it can require non-trivial refactoring.

>> > What if input arrives because of a timer?
>> If this is an issue, I propose input-pending-p return t if a timer is
>> ready to run.
> Likewise: too serious change in behavior for too obscure a reason.

100% agreement.  `input-pending-p' is meant to detect *user input*, and
timers do not count as such (and input generated by timers doesn't
count as "user input" either).


        Stefan





  reply	other threads:[~2013-10-15 13:42 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 17:59 bug#15045: Point jumps inappropriately around time of Semantic lexing Barry OReilly
2013-08-07 18:30 ` Stefan Monnier
2013-08-07 18:42   ` David Engster
2013-08-07 19:31     ` Barry OReilly
2013-08-07 19:44       ` Eli Zaretskii
2013-08-07 20:39         ` Barry OReilly
2013-08-08  2:41           ` Eli Zaretskii
2013-08-08 17:07             ` Barry OReilly
2013-08-08 17:46               ` Eli Zaretskii
2013-08-07 21:23       ` Stefan Monnier
2013-08-08 17:21     ` David Engster
2013-08-08 18:06       ` Stefan Monnier
2013-08-08 18:13         ` David Engster
2013-08-08 21:39         ` Eli Zaretskii
2013-08-08 22:51           ` Stefan Monnier
2013-08-09  7:56             ` Eli Zaretskii
2013-08-09 14:03               ` Stefan Monnier
2013-08-09 14:16                 ` Eli Zaretskii
2013-08-09 17:34                   ` Stefan Monnier
2013-08-09 18:23                     ` Eli Zaretskii
2013-08-08 20:03       ` Barry OReilly
2013-08-08 20:30         ` David Engster
2013-08-08 21:49           ` Eli Zaretskii
2013-08-09  5:36             ` David Engster
2013-08-09  7:53               ` Eli Zaretskii
2013-08-09 11:50                 ` Eric M. Ludlam
2013-08-09 13:31                   ` Eli Zaretskii
2013-08-09 14:04                   ` Stefan Monnier
2013-08-09 14:19                     ` Eli Zaretskii
2013-08-09 18:08                       ` Stefan Monnier
2013-08-09 18:38                         ` Eli Zaretskii
2013-08-09 18:41                           ` David Engster
2013-08-09 20:49                             ` Eli Zaretskii
2013-08-09 21:36                             ` Stefan Monnier
2013-08-10  9:42                               ` David Engster
2013-08-09 21:46                           ` Stefan Monnier
2013-08-09 16:10                 ` David Engster
2013-08-09 18:31                   ` Eli Zaretskii
2013-08-10  9:54                     ` David Engster
2013-08-10 10:22                       ` Eli Zaretskii
2013-08-10 18:06                         ` Barry OReilly
2013-10-14 19:32                           ` Barry OReilly
2013-10-14 19:51                             ` Eli Zaretskii
2013-10-15 13:42                               ` Stefan Monnier [this message]
2013-10-15 14:12                                 ` Barry OReilly
2013-10-15 16:28                                   ` Eli Zaretskii
2013-10-15 17:08                                     ` Barry OReilly
2013-10-15 18:48                                       ` Eli Zaretskii
2013-10-15 19:19                                         ` Barry OReilly
2013-10-16  2:57                                       ` Stefan Monnier
2013-10-16 14:57                                         ` Barry OReilly
2013-10-16 17:50                                           ` Stefan Monnier
2013-10-16 18:32                                             ` Barry OReilly
2013-10-17 15:03                                             ` Barry OReilly
2013-10-17 18:18                                               ` Stefan Monnier
2013-10-17 20:01                                                 ` Barry OReilly
2013-10-18  0:27                                                   ` Stefan Monnier
2013-10-18 14:03                                                     ` Barry OReilly
2013-10-25 19:15                                                       ` Barry OReilly
2013-11-14 18:21                                                         ` Barry OReilly
2013-11-16  4:14                                                           ` Stefan Monnier
2013-11-16  4:54                                                             ` Barry OReilly
2013-11-16 17:37                                                               ` Stefan Monnier
2013-11-16 20:33                                                                 ` Barry OReilly
2013-11-16 21:29                                                                   ` Stefan Monnier
2013-08-09 18:50                   ` Stefan Monnier
2013-08-09  9:12               ` martin rudalics
2013-08-09 16:27                 ` David Engster
2013-08-09 17:10                   ` martin rudalics
2013-08-09 18:51                   ` Stefan Monnier
2013-08-08 21:26         ` Stefan Monnier
2013-08-08 21:57           ` Eli Zaretskii
2013-08-08 22:50             ` Stefan Monnier
2013-08-09  7:54               ` Eli Zaretskii
2013-08-08 21:47         ` Eli Zaretskii
2013-08-09  3:26       ` Eric M. Ludlam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwqlen052.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=15045@debbugs.gnu.org \
    --cc=deng@randomsample.de \
    --cc=eliz@gnu.org \
    --cc=eric@siege-engine.com \
    --cc=gundaetiapo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.