From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Daniel Colascione <dancol@dancol.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117007: Optimize cl-struct-slot-value; fix test
Date: Tue, 22 Apr 2014 00:34:10 -0400 [thread overview]
Message-ID: <jwvwqeikmpw.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1WcRjt-0001M5-8b@vcs.savannah.gnu.org> (Daniel Colascione's message of "Tue, 22 Apr 2014 03:51:21 +0000")
> - (elt inst (cl-struct-slot-offset struct-type slot-name)))
> + ;; We could use `elt', but since the byte compiler will resolve the
> + ;; branch below at compile time, it's more efficient to use the
> + ;; type-specific accessor.
> + (if (eq (cl-struct-sequence-type struct-type) 'vector)
> + (aref inst (cl-struct-slot-offset struct-type slot-name))
> + (nth (cl-struct-slot-offset struct-type slot-name) inst)))
It won't always resolve the (eq (cl-struct-sequence-type struct-type)
'vector) test at compile-time, tho.
Stefan
next parent reply other threads:[~2014-04-22 4:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WcRjt-0001M5-8b@vcs.savannah.gnu.org>
2014-04-22 4:34 ` Stefan Monnier [this message]
2014-04-22 4:35 ` [Emacs-diffs] trunk r117007: Optimize cl-struct-slot-value; fix test Daniel Colascione
2014-04-22 15:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwqeikmpw.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.