all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#17388: 24.4.50; REGRESSION: Ediff - 1) wrong face, 2) incorrect diffing
@ 2014-05-02 15:15 Drew Adams
  2014-05-02 18:57 ` Stephen Berman
  0 siblings, 1 reply; 12+ messages in thread
From: Drew Adams @ 2014-05-02 15:15 UTC (permalink / raw)
  To: 17388

[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]

1. A diff that is not the current one should use face
`ediff-(odd|even)-diff-(A|B').  This is now broken.

It does use that face for the main diff, but it still tries to show fine
differences within that diff - which is new.  That would be OK, I guess,
but it should not use face `default' to show such fine diffs.  It should
use an Ediff face, which users can customize without affecting other
things (as happens with `default').

Using face `default' here is particular misguided, as it suggests that
there is no difference at those locations, whereas there likely is.

See the attached screenshot.  The first diff shown, with the gray
highlighting, shows the regression.  


2. The fine diffs are also not correct.  See the same screenshot.  For
the first diff, "advertise" and "d-signature-table" should be
highlighted the same as "(defvar " and ")", and for the second diff,
"fil" and "s-alist" should be highlighted the same as "(defvar " and
")".  These are not differences.

I am using Cygwin `diff', which could affect #2 presumably.  But #2 is
still a regression wrt prior Emacs versions.  With Emacs 24.3, for
instance (using the same Cygwin `diff'), there is no fine diff shown
here.  Instead, the diff, which is shown only as a main diff, is between
"file-local-variables-alist" and "filxxxxxxxxxxxxxxxxxxxxxs-alist".
Which is correct.

Emacs should not show fine diffs that are are patently wrong.
Better not to mislead.



In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-04-29 on ODIEONE
Bzr revision: 117031 monnier@iro.umontreal.ca-20140429151607-qnkgbymwfaj5ut08
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

[-- Attachment #2: throw-emacs-bug-ediff.png --]
[-- Type: image/png, Size: 19965 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread
[parent not found: <<eb90ee40-d0cb-46f0-8ce1-1759d110cbbd@default>]

end of thread, other threads:[~2014-05-04  7:16 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-02 15:15 bug#17388: 24.4.50; REGRESSION: Ediff - 1) wrong face, 2) incorrect diffing Drew Adams
2014-05-02 18:57 ` Stephen Berman
2014-05-03  2:27   ` Stefan Monnier
2014-05-03  3:11     ` Drew Adams
2014-05-03  6:48       ` Eli Zaretskii
     [not found] <<eb90ee40-d0cb-46f0-8ce1-1759d110cbbd@default>
     [not found] ` <<87wqe43t55.fsf@rosalinde.fritz.box>
     [not found]   ` <<jwvwqe3mx1m.fsf-monnier+emacsbugs@gnu.org>
     [not found]     ` <<111c9271-6a23-426e-adb2-ff5520c02806@default>
     [not found]       ` <<83a9az1hok.fsf@gnu.org>
2014-05-03 14:01         ` Drew Adams
2014-05-03 16:42           ` Eli Zaretskii
     [not found]         ` <8613042fc3be4f9995e33e38d4f079f0@HUBCAS1.cs.stonybrook.edu>
2014-05-03 15:57           ` Michael Kifer
2014-05-03 20:41             ` Drew Adams
2014-05-04  3:54               ` Stefan Monnier
2014-05-04  7:16                 ` Drew Adams
     [not found]         ` <<bbf71aaa-f669-4542-a8d1-b7ff9d40d66e@default>
     [not found]           ` <<83y4yizue3.fsf@gnu.org>
2014-05-03 20:56             ` Drew Adams

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.