From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117640: * keyboard.c (safe_run_hook_funcall): Avoid consing around
Date: Mon, 04 Aug 2014 18:35:56 -0400 [thread overview]
Message-ID: <jwvwqansx28.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <53DF4423.6050101@yandex.ru> (Dmitry Antipov's message of "Mon, 04 Aug 2014 12:28:19 +0400")
>> You remove the comment but don't fix the code accordingly: if the FIXME
>> is not valid any more, than we should cleanly pass `hook' as argument
>> rather than let-binding it to inhibit-quit.
> Hm...isn't it required to bind inhibit-quit to non-nil value before running
> hooks?
Yes, binding it to a non-nil value is necessary. But that doesn't mean
that hook needs to be passed via that dynamic var.
Stefan
prev parent reply other threads:[~2014-08-04 22:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1XE9Us-00047U-Id@vcs.savannah.gnu.org>
2014-08-04 7:28 ` [Emacs-diffs] trunk r117640: * keyboard.c (safe_run_hook_funcall): Avoid consing around Stefan Monnier
2014-08-04 8:28 ` Dmitry Antipov
2014-08-04 22:35 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwqansx28.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.