From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18413: Inline part displayed in the middle of its button Date: Fri, 05 Sep 2014 14:09:16 -0400 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1409940691 16315 80.91.229.3 (5 Sep 2014 18:11:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Sep 2014 18:11:31 +0000 (UTC) To: 18413@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 05 20:11:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XPxyk-0006FQ-Ty for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Sep 2014 20:11:23 +0200 Original-Received: from localhost ([::1]:59584 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPxyk-0004dh-9U for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Sep 2014 14:11:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPxyZ-0004ck-EH for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 14:11:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPxyR-0001Ba-Cx for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 14:11:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPxyR-0001BW-A6 for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 14:11:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XPxyQ-0004eP-BV; Fri, 05 Sep 2014 14:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 05 Sep 2014 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18413 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.140994061517812 (code B ref -1); Fri, 05 Sep 2014 18:11:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Sep 2014 18:10:15 +0000 Original-Received: from localhost ([127.0.0.1]:60062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPxxf-0004dE-5E for submit@debbugs.gnu.org; Fri, 05 Sep 2014 14:10:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41251) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPxxc-0004d0-Ed for submit@debbugs.gnu.org; Fri, 05 Sep 2014 14:10:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPxxP-0000mF-0p for submit@debbugs.gnu.org; Fri, 05 Sep 2014 14:10:07 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:49617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPxxO-0000mB-Ty for submit@debbugs.gnu.org; Fri, 05 Sep 2014 14:09:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPxxH-0004Sj-Jh for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 14:09:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPxx8-0000dV-Cq for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 14:09:49 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:42250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPxx8-0000cb-5O for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 14:09:42 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id D5EA685039 for ; Fri, 5 Sep 2014 14:09:41 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 652BB1E5B8A for ; Fri, 5 Sep 2014 14:09:16 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 43388B41B5; Fri, 5 Sep 2014 14:09:16 -0400 (EDT) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93080 Archived-At: Package: emacs,gnus Version: 24.4.50 Here's what I do: - start Gnus - visit a message with an Elisp attachment (in my case I tested with a message from Tom on emacs-devel with subject "Re: History for query replace pairs" and with an attachment of type "application/emacs-lisp"). - place cursor in the middle of the attachment's button (using keyboard commands). - press E Result: the attachment is shown inline, but right in the middle of the button. IOW I get "[4. applicati" (from the button's text before point), followed by the attachment's content, followed by "on/emacs-lisp; hist.el]". The whole is in bold for me, because the button is an overlay with `bold' face, so the face ends up covering the inline attachment as well. It seems to be the result of the hunk below. Stefan revno: 117041 committer: Katsumi Yamaoka branch nick: trunk timestamp: Fri 2014-05-02 09:44:34 +0000 message: Gnus: Make gnus-mime-inline-part and gnus-mime-inline-part work similarly * gnus-art.el (gnus-mime-inline-part): Redisplay a button so as to show the displaying state of a part. (gnus-mime-inline-part): Don't insert a newline in the beginning of a part like gnus-mime-inline-part doesn't; work for XEmacs. * mm-decode.el (mm-display-part): Don't insert a newline in the top. (mm-shr): Make undisplayer unbreakable. * mm-view.el (mm-inline-image-emacs, mm-inline-image-xemacs): Don't insert excessive newline. (mm-inline-text-html-render-with-w3m, mm-inline-text) (mm-insert-inline): Make undisplayer unbreakable. --- lisp/gnus/mm-decode.el 2014-03-23 23:13:36 +0000 +++ lisp/gnus/mm-decode.el 2014-05-02 09:44:34 +0000 @@ -821,7 +821,6 @@ 'inline) ((and (mm-inlinable-p ehandle) (mm-inlined-p ehandle)) - (forward-line 1) (mm-display-inline handle) 'inline) ((or method