From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18729: [PATCH] subr.el (set-key): New macro making creating new bindings more concise. Date: Wed, 15 Oct 2014 10:20:33 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1413382897 5677 80.91.229.3 (15 Oct 2014 14:21:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Oct 2014 14:21:37 +0000 (UTC) Cc: 18729@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 15 16:21:29 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XePSA-0004Ea-N1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Oct 2014 16:21:26 +0200 Original-Received: from localhost ([::1]:45006 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XePS6-0001gE-GK for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Oct 2014 10:21:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XePRv-0001e2-Kx for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2014 10:21:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XePRm-0000tO-IX for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2014 10:21:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XePRm-0000tK-Fw for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2014 10:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XePRm-0004o2-2g for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2014 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Oct 2014 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18729-submit@debbugs.gnu.org id=B18729.141338283818432 (code B ref 18729); Wed, 15 Oct 2014 14:21:02 +0000 Original-Received: (at 18729) by debbugs.gnu.org; 15 Oct 2014 14:20:38 +0000 Original-Received: from localhost ([127.0.0.1]:44548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XePRN-0004nD-AY for submit@debbugs.gnu.org; Wed, 15 Oct 2014 10:20:37 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:1595) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XePRK-0004n5-Ro for 18729@debbugs.gnu.org; Wed, 15 Oct 2014 10:20:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNFxKjo/2dsb2JhbABZgwaDSsA9gRcXdIImAQEEViMQCw4mEhQYDSSIDNIZF456B4Q4BKkZgWqBcYFbIQ X-IPAS-Result: ArUGAIDvNVNFxKjo/2dsb2JhbABZgwaDSsA9gRcXdIImAQEEViMQCw4mEhQYDSSIDNIZF456B4Q4BKkZgWqBcYFbIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="94260859" Original-Received: from 69-196-168-232.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.232]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 15 Oct 2014 10:20:34 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id CD1A87CFB; Wed, 15 Oct 2014 10:20:33 -0400 (EDT) In-Reply-To: (Michal Nazarewicz's message of "Wed, 15 Oct 2014 09:48:49 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:94533 > +(defmacro set-key (keymap key &rest def) I'm not convinced the added complexity is worth the trouble, I'm afraid. I don't see a real benefit in (set-key :global KEY CMD) (set-key :local KEY CMD) (set-key MAP KEY CMD) over (global-set-key KEY CMD) (local-set-key KEY CMD) (define-key MAP KEY CMD) or (define-key global-map KEY CMD) (define-key (current-local-map) KEY CMD) (define-key MAP KEY CMD) I also don't see the benefit of (:args ARGS INTERACTIVE . BODY) over (lambda ARGS (interactive INTERACTIVE) . BODY). The only thing I think is really valuable is things like (set-key ... KEY (dired "foo")) For which there is also a precedent in easy-define-menu (where the CMD can be either a symbol or an expression, in which case that expression gets wrapped in (lambda () (interactive) ...)). Maybe we could simply extend define-key to accept (define-key MAP KEY '(dired "foo")) -- Stefan