From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18886: 24.4; M-v no longer works in CUA-mode. Date: Thu, 30 Oct 2014 15:23:06 -0400 Message-ID: References: <54526B57.8080508@cua.dk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1414772033 22708 80.91.229.3 (31 Oct 2014 16:13:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Oct 2014 16:13:53 +0000 (UTC) Cc: 18886@debbugs.gnu.org To: Kim Storm Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 31 17:13:46 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XkEpd-00018n-FL for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Oct 2014 17:13:45 +0100 Original-Received: from localhost ([::1]:38768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkEpc-0006oO-Pu for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Oct 2014 12:13:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkE99-0004zr-5w for bug-gnu-emacs@gnu.org; Fri, 31 Oct 2014 11:30:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjvKE-0005yn-5t for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2014 15:24:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjvKE-0005ye-27 for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2014 15:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XjvKD-0004qW-Ot for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2014 15:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Oct 2014 19:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18886 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18886-submit@debbugs.gnu.org id=B18886.141469699118555 (code B ref 18886); Thu, 30 Oct 2014 19:24:01 +0000 Original-Received: (at 18886) by debbugs.gnu.org; 30 Oct 2014 19:23:11 +0000 Original-Received: from localhost ([127.0.0.1]:40855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XjvJO-0004pC-N7 for submit@debbugs.gnu.org; Thu, 30 Oct 2014 15:23:10 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:53005) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XjvJM-0004p4-H6 for 18886@debbugs.gnu.org; Thu, 30 Oct 2014 15:23:09 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s9UJN452003172; Thu, 30 Oct 2014 15:23:04 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 36C42660F3; Thu, 30 Oct 2014 15:23:06 -0400 (EDT) In-Reply-To: <54526B57.8080508@cua.dk> (Kim Storm's message of "Thu, 30 Oct 2014 17:46:15 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5110=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5110> : inlines <1462> : streams <1330653> : uri <1830513> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:95295 > I don't have time to try to get up to date with the repository stuff, > so I have just included some patches for you to look at -- please > commit them if you think they are acceptable (they are only lightly > tested so far). Thanks, installed into emacs-24, with minor changes (mostly I demoted the defcustom to a defvar, because I think the right fix will be to move the setting to simple.el where it will be configured yet differently (probably allowing delete-active-region to be set to a character)). I think further changes will be needed, tho. E.g. cua-delete-region should probably disappear (i.e. be an alias for delete-active-region). > Note that the new defcustom is unconditionally set to ?0 > by cua-mode if cua-mode-copy-to-register-0 is enabled (default), Right, I added a FIXME about it. > Also, the new replace command only works if save-to-register > is non-nil, as it uses the old-text copy in that register (instead > of saving another copy as the original code in cua did). BTW, I think that instead of scavenging the undo log we should place an overlay at the last delete so we can directly grab the "replacement text". > Finally, using a C-u arg should replace until eob according to the > doc string -- it actually replaces max 1000000 instances; this > is just laziness on my part. I used (point-max) which should work well and is only 4 extra characters ;-) Stefan