From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Kim Storm <storm@cua.dk>
Cc: 18886@debbugs.gnu.org
Subject: bug#18886: 24.4; M-v no longer works in CUA-mode.
Date: Thu, 30 Oct 2014 15:23:06 -0400 [thread overview]
Message-ID: <jwvwq7h76kg.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <54526B57.8080508@cua.dk> (Kim Storm's message of "Thu, 30 Oct 2014 17:46:15 +0100")
> I don't have time to try to get up to date with the repository stuff,
> so I have just included some patches for you to look at -- please
> commit them if you think they are acceptable (they are only lightly
> tested so far).
Thanks, installed into emacs-24, with minor changes (mostly I demoted
the defcustom to a defvar, because I think the right fix will be to move
the setting to simple.el where it will be configured yet differently
(probably allowing delete-active-region to be set to a character)).
I think further changes will be needed, tho. E.g. cua-delete-region
should probably disappear (i.e. be an alias for delete-active-region).
> Note that the new defcustom is unconditionally set to ?0
> by cua-mode if cua-mode-copy-to-register-0 is enabled (default),
Right, I added a FIXME about it.
> Also, the new replace command only works if save-to-register
> is non-nil, as it uses the old-text copy in that register (instead
> of saving another copy as the original code in cua did).
BTW, I think that instead of scavenging the undo log we should place an
overlay at the last delete so we can directly grab the "replacement text".
> Finally, using a C-u arg should replace until eob according to the
> doc string -- it actually replaces max 1000000 instances; this
> is just laziness on my part.
I used (point-max) which should work well and is only 4 extra characters ;-)
Stefan
next prev parent reply other threads:[~2014-10-30 19:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 16:54 bug#18886: 24.4; M-v no longer works in CUA-mode Kim F. Storm
2014-10-30 0:47 ` Stefan Monnier
2014-10-30 16:46 ` Kim Storm
2014-10-30 19:23 ` Stefan Monnier [this message]
2014-10-30 20:39 ` Kim Storm
2014-11-02 17:04 ` Kim Storm
2016-06-26 17:55 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwq7h76kg.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=18886@debbugs.gnu.org \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.