From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Oleh Krehel <ohwoeowho@gmail.com>
Subject: Re: [elpa] master 9f21e1d 06/18: Add a matching optimization
Date: Mon, 20 Apr 2015 11:02:45 -0400 [thread overview]
Message-ID: <jwvwq16etfg.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1YkAyd-0005aA-JJ@vcs.savannah.gnu.org> (Oleh Krehel's message of "Mon, 20 Apr 2015 12:39:03 +0000")
> * ivy.el (ivy-completions): When the new regex `re' is a contains the
> old regex `ivy--old-re', it must be true that all candidates that
> match `re' are contained inside all candidates that match
IIUC ivy-mode treats the minibuffer's content as a regexp, so the user
can write any fancy regexp she wants. In that case, the above is
actually not guaranteed. E.g. "foo" matches fewer candidates than
"foo?".
> + ((and ivy--old-re (eq 0 (cl-search ivy--old-re re)))
Why not use string-prefix-p?
Stefan
next parent reply other threads:[~2015-04-20 15:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150420123900.21320.5807@vcs.savannah.gnu.org>
[not found] ` <E1YkAyd-0005aA-JJ@vcs.savannah.gnu.org>
2015-04-20 15:02 ` Stefan Monnier [this message]
2015-04-20 15:08 ` [elpa] master 9f21e1d 06/18: Add a matching optimization Oleh Krehel
2015-04-20 17:29 ` Artur Malabarba
2015-04-20 17:29 ` Oleh Krehel
[not found] ` <E1YkAyb-0005Z5-GL@vcs.savannah.gnu.org>
2015-04-20 15:08 ` [elpa] master a94ca83 01/18: swiper.el: Add a work-around for window-start not being current Stefan Monnier
2015-04-20 15:19 ` Oleh Krehel
2015-04-20 19:46 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwq16etfg.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.