From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Small fix in `shell--unquote&requote-argument' - please review Date: Wed, 31 Aug 2016 09:27:54 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1472721714 26882 195.159.176.226 (1 Sep 2016 09:21:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Sep 2016 09:21:54 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 01 11:21:50 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfOBt-00069T-Cw for ged-emacs-devel@m.gmane.org; Thu, 01 Sep 2016 11:21:45 +0200 Original-Received: from localhost ([::1]:35821 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfOBu-0004Fr-C4 for ged-emacs-devel@m.gmane.org; Thu, 01 Sep 2016 05:21:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfO8s-0001cp-Ln for emacs-devel@gnu.org; Thu, 01 Sep 2016 05:18:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfO8l-0005BV-4Q for emacs-devel@gnu.org; Thu, 01 Sep 2016 05:18:37 -0400 Original-Received: from [195.159.176.226] (port=39243 helo=blaine.gmane.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfO8k-0005Ak-UZ for emacs-devel@gnu.org; Thu, 01 Sep 2016 05:18:31 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1bf5Vh-0007eF-S8 for emacs-devel@gnu.org; Wed, 31 Aug 2016 15:24:57 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 11 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:R5DoD/WXiDa1PfoeCgvTb5dRap8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207050 Archived-At: > 1. match is always less than (length str), so I guess they meant > `((< (1+ match) (length qstr))'. > 2. If `string-match' searching for ending single quote failed, > `(match-string 0)' is still called - be careful not to do this. Do you have corresponding recipes to trigger the corresponding errors (so we could write tests)? This part of my code is in dire need of tests, otherwise it's much too easy to introduce regressions. Stefan