From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix Date: Sat, 17 Dec 2016 17:08:53 -0500 Message-ID: References: <20161212202151.21054.37035@vcs.savannah.gnu.org> <20161212202152.428192201BB@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482012555 18677 195.159.176.226 (17 Dec 2016 22:09:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Dec 2016 22:09:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 17 23:09:11 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cINAD-0003nG-2r for ged-emacs-devel@m.gmane.org; Sat, 17 Dec 2016 23:09:09 +0100 Original-Received: from localhost ([::1]:38437 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cINAH-0001tU-8y for ged-emacs-devel@m.gmane.org; Sat, 17 Dec 2016 17:09:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cINAB-0001lr-56 for emacs-devel@gnu.org; Sat, 17 Dec 2016 17:09:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cINA6-0005lt-6y for emacs-devel@gnu.org; Sat, 17 Dec 2016 17:09:07 -0500 Original-Received: from [195.159.176.226] (port=41503 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cINA6-0005lg-0D for emacs-devel@gnu.org; Sat, 17 Dec 2016 17:09:02 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cIN9y-0001Of-Gw for emacs-devel@gnu.org; Sat, 17 Dec 2016 23:08:54 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 9 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:9x9+Xc/VL/N4G9zXBRGNzWjDYP4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210593 Archived-At: > Yes, fset for most primitives should be forbidden. Define "most". That would mean we can't use advise, trace-function, debug-on-entry, or elp on them. There are very legitimate reasons to fset them. Stefan