From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [SUSPECTED SPAM] Re: [Emacs-diffs] scratch/widen-less a4ba846: Replace prog-widen with consolidating widen calls Date: Mon, 04 Dec 2017 16:00:13 -0500 Message-ID: References: <20171129233237.27462.23351@vcs0.savannah.gnu.org> <27985594-3bb4-ce88-8928-2ccfeac13eae@yandex.ru> <20171201154913.GB3840@ACM> <1e542021-e389-cca4-6acd-349efddb2652@yandex.ru> <20171201223529.GG3840@ACM> <4a94ec5c-efdd-50f1-ff4d-277f5f45c2df@yandex.ru> <83lgil1qme.fsf@gnu.org> <83d13x1j2s.fsf@gnu.org> <34abea95-c7f7-e8fa-8407-8c2fd2a4cfe1@yandex.ru> <83y3mkzw1n.fsf@gnu.org> <83mv2zzv7z.fsf@gnu.org> <83o9nexy48.fsf@gnu.org> <83d13uxug5.fsf@gnu.org> <83a7yyxoan.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1512421261 18414 195.159.176.226 (4 Dec 2017 21:01:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 4 Dec 2017 21:01:01 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 04 22:00:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLxrF-0004Zs-Ay for ged-emacs-devel@m.gmane.org; Mon, 04 Dec 2017 22:00:57 +0100 Original-Received: from localhost ([::1]:45204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLxrL-0000CL-6u for ged-emacs-devel@m.gmane.org; Mon, 04 Dec 2017 16:01:03 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLxqh-0000C9-OZ for emacs-devel@gnu.org; Mon, 04 Dec 2017 16:00:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLxqd-0004Jz-V8 for emacs-devel@gnu.org; Mon, 04 Dec 2017 16:00:23 -0500 Original-Received: from pmta11.teksavvy.com ([76.10.157.34]:45516) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLxqZ-0004CV-Bo; Mon, 04 Dec 2017 16:00:15 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2E7RQDVtiVa/7mYWxdcHAEBAQQBAQoBA?= =?us-ascii?q?YM8gVSDW4pSjxOBfZkWhUUChTREEwEBAQEBAQEBAQNoKIUkAQQBeRALDScHCxQ?= =?us-ascii?q?YMYotCKovIQKKPQEBAQEGAgElg0eCCoZqixkFkxqPUqELKIc0mAc3IoFNMhoIM?= =?us-ascii?q?DqBZUWCTh8ZgWwjik0BAQE?= X-IPAS-Result: =?us-ascii?q?A2E7RQDVtiVa/7mYWxdcHAEBAQQBAQoBAYM8gVSDW4pSjxO?= =?us-ascii?q?BfZkWhUUChTREEwEBAQEBAQEBAQNoKIUkAQQBeRALDScHCxQYMYotCKovIQKKP?= =?us-ascii?q?QEBAQEGAgElg0eCCoZqixkFkxqPUqELKIc0mAc3IoFNMhoIMDqBZUWCTh8ZgWw?= =?us-ascii?q?jik0BAQE?= X-IronPort-AV: E=Sophos;i="5.45,361,1508817600"; d="scan'208";a="11161771" Original-Received: from unknown (HELO pastel.home) ([23.91.152.185]) by smtp.teksavvy.com with ESMTP; 04 Dec 2017 16:00:13 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 567E361367; Mon, 4 Dec 2017 16:00:13 -0500 (EST) In-Reply-To: <83a7yyxoan.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 04 Dec 2017 21:53:36 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.10.157.34 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220719 Archived-At: >> AFAICT prog-widen doesn't look at the PREVIOUS-CHUNK part of >> prog-indentation-context. > But it looks at the other data in prog-indentation-context, and > PREVIOUS-CHUNK, if it's a function, could store there something. > Or a mode could use some other method to store the previous > restriction directly in prog-indentation-context. Right? My point is that currently, I can only find 3 bytes of code which do anything with PREVIOUS-CHUNK, it's in mhtml-mode.el where they do: (let ((prog-indentation-context (list base-indent (cons (point-min) nil) nil))) where the last `nil` is actually the PREVIOUS-CHUNK (we could remove that `nil` and it would make no difference, tho). It really only exists in the docstring. >> >> Zero is not the intention: for the doc changes to be valid, we need to >> >> add a few `widen` calls in places like indent-according-to-mode. >> > If those calls are conditioned on MMM actually being active, then >> > existing behavior will remain unchanged, and we are good. >> How do you propose we detect when MMM is active? > I don't know (didn't look at its sources close enough), but I'd be > surprised if there wasn't some variable or some other method to tell. I'd rather not hard code knowledge of mmm-mode as *the* MMM system. Maybe we should just forget about this whole thing for emacs-26 and move on to emacs-27. Stefan