all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: m43cap@yandex.com, 30955@debbugs.gnu.org
Subject: bug#30955: 27.0.50; Mouse clicks on header-line in Info are broken
Date: Thu, 29 Mar 2018 08:10:03 -0400	[thread overview]
Message-ID: <jwvwoxv84z4.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <838tabdu3x.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Mar 2018 14:00:34 +0300")

>> >         Stefan "not looking forward to debug sessions in read_key_sequence"
>> Ha, I found the sucker!
>> Installed,
> Thanks.  The original bug is fixed, but I still don't understand
> something related.  If I do "C-h c" and click mouse-1 on the Up link
> on the header-line, I see this in the echo area:
>
>   <header-line> <down-mouse-1> (translated from <down-mouse-1>) at that spot
> runs the command mouse-drag-header-line
>   <header-line> <mouse-2> (translated from <mouse-2>) at that spot runs the
> command Info-mouse-follow-link
>
> Why does the second line talk about mouse-2?  I didn't click that
> button.  I'd expect to see only mouse-1 mentioned in both lines.

To figure out what that click would run (Info-mouse-follow-link in this
case), we have to perform the same translation as if you actually
performed the action.

There's indeed a bug, here, which is that it says

    (translated from <mouse-2>)

instead of

    (translated from <mouse-1>)

I assume it's because the fix I installed modifies the event in-place,
so the recording of "untranslated events" gets changed by side-effect.
Maybe we should record *copies* of events in there, to avoid this?


        Stefan





  reply	other threads:[~2018-03-29 12:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 14:54 bug#30955: 27.0.50; Mouse clicks on header-line in Info are broken Eli Zaretskii
2018-03-27 18:46 ` Stefan Monnier
2018-03-27 19:27   ` Stefan Monnier
2018-03-28  6:07     ` Colin Baxter
2018-03-29 11:00     ` Eli Zaretskii
2018-03-29 12:10       ` Stefan Monnier [this message]
2018-03-29 12:24         ` Eli Zaretskii
2018-03-29 13:11           ` Stefan Monnier
2018-03-29 13:30             ` Colin Baxter
2018-03-31 17:18             ` Eli Zaretskii
2018-03-31 18:56               ` Colin Baxter
2018-03-31 19:03                 ` Eli Zaretskii
2018-03-31 19:16                   ` Eli Zaretskii
2018-03-31 20:59                     ` Colin Baxter
2018-03-31 20:55                   ` Colin Baxter
2018-03-31 23:40               ` Stefan Monnier
2018-04-01  6:50                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwoxv84z4.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=30955@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=m43cap@yandex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.