From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#27822: [PATCH] do not auto-remove external packages (fixes #27822) Date: Tue, 17 Jul 2018 08:40:52 -0400 Message-ID: References: <87y3rc8thp.fsf@wavexx.thregr.org> <877elugljf.fsf@wavexx.thregr.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531831153 30703 195.159.176.226 (17 Jul 2018 12:39:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Jul 2018 12:39:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 27822@debbugs.gnu.org To: "Yuri D'Elia" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 17 14:39:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffPG0-0007sb-DM for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jul 2018 14:39:08 +0200 Original-Received: from localhost ([::1]:59072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffPI7-0000Zl-B4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jul 2018 08:41:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffPHv-0000YV-HH for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 08:41:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffPHq-00012G-La for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 08:41:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39543) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffPHq-000122-GY for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 08:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ffPHq-0003AG-7I for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 08:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jul 2018 12:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27822 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27822-submit@debbugs.gnu.org id=B27822.153183125712145 (code B ref 27822); Tue, 17 Jul 2018 12:41:02 +0000 Original-Received: (at 27822) by debbugs.gnu.org; 17 Jul 2018 12:40:57 +0000 Original-Received: from localhost ([127.0.0.1]:44561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffPHk-00039m-AO for submit@debbugs.gnu.org; Tue, 17 Jul 2018 08:40:57 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:42683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffPHh-00039e-Q5 for 27822@debbugs.gnu.org; Tue, 17 Jul 2018 08:40:55 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w6HCfYiS010369; Tue, 17 Jul 2018 08:41:35 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1C1D265723; Tue, 17 Jul 2018 08:40:52 -0400 (EDT) In-Reply-To: <877elugljf.fsf@wavexx.thregr.org> (Yuri D'Elia's message of "Tue, 17 Jul 2018 13:16:04 +0200") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6331=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6331> : inlines <6753> : streams <1792806> : uri <2674969> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148607 Archived-At: [ Please don't crosspost between bugs and emacs-devel. ] > package-autoremove however will still attempt to remove them. My feeling > is that any package which is not directly in 'package-user-dir shouldn't > be autoremoved. AFAIK packages installed via dpkg can't be removed (lack of access rights), so attempting to remove them is not that big of a deal, is it? Or does it signal an error, prevent local packages from being auto-removed, or something (I mean, beside the philosophical argument, does it result in an actual harmful behavior in practice)? > The following patch checks whether a package has been _directly_ installed > into `package-user-dir' before marking it eligible for auto-removal. Looks good to me, Stefan