From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: "Yuri D'Elia" <wavexx@thregr.org>
Cc: 27822@debbugs.gnu.org
Subject: bug#27822: [PATCH] do not auto-remove external packages (fixes #27822)
Date: Tue, 17 Jul 2018 08:40:52 -0400 [thread overview]
Message-ID: <jwvwotuyr2x.fsf-monnier+bug#27822@gnu.org> (raw)
In-Reply-To: <877elugljf.fsf@wavexx.thregr.org> (Yuri D'Elia's message of "Tue, 17 Jul 2018 13:16:04 +0200")
[ Please don't crosspost between bugs and emacs-devel. ]
> package-autoremove however will still attempt to remove them. My feeling
> is that any package which is not directly in 'package-user-dir shouldn't
> be autoremoved.
AFAIK packages installed via dpkg can't be removed (lack of access
rights), so attempting to remove them is not that big of a deal, is it?
Or does it signal an error, prevent local packages from being
auto-removed, or something (I mean, beside the philosophical argument,
does it result in an actual harmful behavior in practice)?
> The following patch checks whether a package has been _directly_ installed
> into `package-user-dir' before marking it eligible for auto-removal.
Looks good to me,
Stefan
next prev parent reply other threads:[~2018-07-17 12:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 14:46 bug#27822: 26.0.50; package-autoremove and 'package-directory-list Yuri D'Elia
2018-07-17 11:16 ` bug#27822: [PATCH] do not auto-remove external packages (fixes #27822) Yuri D'Elia
2018-07-17 11:16 ` Yuri D'Elia
2018-07-17 12:40 ` Stefan Monnier [this message]
2018-07-17 12:50 ` bug#27822: " Yuri D'Elia
2018-08-07 11:12 ` package.el fix (was Re: [PATCH] do not auto-remove external packages (fixes #27822)) Yuri D'Elia
2018-08-09 1:19 ` bug#27822: [PATCH] do not auto-remove external packages (fixes #27822) Noam Postavsky
2018-08-09 11:16 ` Yuri D'Elia
2018-08-09 15:24 ` Eli Zaretskii
2018-08-12 1:08 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jwvwotuyr2x.fsf-monnier+bug#27822@gnu.org' \
--to=monnier@iro.umontreal.ca \
--cc=27822@debbugs.gnu.org \
--cc=wavexx@thregr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.