From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [RFC]: replace-region-contents Date: Sat, 02 Feb 2019 10:42:00 -0500 Message-ID: References: <871s4rqk7u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="108870"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 03 16:08:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqJNt-000SCq-DZ for ged-emacs-devel@m.gmane.org; Sun, 03 Feb 2019 16:08:37 +0100 Original-Received: from localhost ([127.0.0.1]:56657 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqJNs-0006fa-Bc for ged-emacs-devel@m.gmane.org; Sun, 03 Feb 2019 10:08:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqJMd-0006dD-88 for emacs-devel@gnu.org; Sun, 03 Feb 2019 10:07:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqJMc-0001pH-Bp for emacs-devel@gnu.org; Sun, 03 Feb 2019 10:07:19 -0500 Original-Received: from [195.159.176.226] (port=43474 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gqJMc-0001lt-1B for emacs-devel@gnu.org; Sun, 03 Feb 2019 10:07:18 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1gqJMY-000QgK-Gh for emacs-devel@gnu.org; Sun, 03 Feb 2019 16:07:14 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:fHa9/MRa7jhXYjFPh13MsU63pGg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232932 Archived-At: > ;; in subr-x.el (or wherever you please) > (defun replace-region-contents (beg end extract-fn inject-fn) > "Replace the region between BEG and END using EXTRACT-FN and INJECT-FN. > > The current buffer is narrowed to the region between BEG and END, > then EXTRACT-FN is called in order to extract some value. > Thereafter, INJECT-FN is called with that value in a temporary > buffer which it should populate. Why two functions instead of just one? Also, I think the docstring should hint at the fact that this is meant for cases where the before and after text share significant parts (so there's a chance of meaningfully preserving markers). It might do that simply be referring to `replace-buffer-contents`. > (atomic-change-group Why? AFAICT the buffer is not modified until we get to calling replace-buffer-contents which already has (or should have) the atomicity property. Stefan PS: BTW, maybe replace-buffer-contents should be changed so it interprets a string argument as the text to use as replacement rather than as a buffer name.