From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] Package proposal: relint (ex-trawl) Date: Wed, 20 Mar 2019 09:08:17 -0400 Message-ID: References: <16A56C60-DD30-4320-823B-E74CF020E49E@acm.org> <83tvfyu4cx.fsf@gnu.org> <83d0mmt7mf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="240992"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 20 14:08:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6axT-0010SN-2e for ged-emacs-devel@m.gmane.org; Wed, 20 Mar 2019 14:08:39 +0100 Original-Received: from localhost ([127.0.0.1]:47807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6axR-0002GJ-VH for ged-emacs-devel@m.gmane.org; Wed, 20 Mar 2019 09:08:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6axG-0002FF-7W for emacs-devel@gnu.org; Wed, 20 Mar 2019 09:08:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h6axF-0004ro-43 for emacs-devel@gnu.org; Wed, 20 Mar 2019 09:08:26 -0400 Original-Received: from [195.159.176.226] (port=37768 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h6axE-0004lJ-9f for emacs-devel@gnu.org; Wed, 20 Mar 2019 09:08:25 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h6axC-0010Ab-By for emacs-devel@gnu.org; Wed, 20 Mar 2019 14:08:22 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:SMR0n2BfHZbLnLrpZSNKcFqNZkg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234404 Archived-At: > My point is that "make check" is supposed to be an integral part of > any serious build of a program, including Emacs. Whenever I build > Emacs for the first time on some machine, I always run the test suite. I don't think relint should be part of `make check` since its purpose is very different (it doesn't try to verify the functional correctness of the code by running it). It should be a separate `make relint`. You use `make check` above as a way to (try to) ensure that a build is functional, and running relint will not help with that since it only looks at the source code and not the resulting behavior. Stefan