Re: master f131e39: * lisp/cedet/mode-local.el: Clean up name space

Re: master f131e39: * lisp/cedet/mode-local.el: Clean up name space

[Stefan Kangas]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> branch: master
> commit f131e396f8a32003b795456130ea37efa6ff41eb
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     * lisp/cedet/mode-local.el: Clean up name space
>
>     Mostly renaming functions by adding `mode-local--` to their name
>     and leaving an obsolete alias behind, just in case.
>
>     (define-child-mode): Make obsolete.

This lead to the following warnings:

  ELC      cedet/semantic/decorate/mode.elc
‘define-child-mode’ is an obsolete macro (as of 27.1); use
‘define-derived-mode’ instead.
  ELC      emacs-lisp/chart.elc
‘define-child-mode’ is an obsolete macro (as of 27.1); use
‘define-derived-mode’ instead.

Best regards,
Stefan Kangas

with-suppressed-warnings ineffective?

[Stefan Monnier]

Hi Lars,

Another brilliant Stefan pointed out that we have undesired warnings:

  ELC      cedet/semantic/bovine/c.elc
‘define-child-mode’ is an obsolete macro (as of 27.1); use ‘define-derived-mode’ instead.
  ELC      cedet/semantic/bovine/el.elc
‘define-child-mode’ is an obsolete macro (as of 27.1); use ‘define-derived-mode’ instead.

[ Not sure if the file names are right above.  ]

AFAICT these come from

    (with-suppressed-warnings ((obsolete define-child-mode))
      ;; FIXME: We should handle this some other way!
      (define-child-mode c++-mode c-mode
      "`c++-mode' uses the same parser as `c-mode'."))
and
    (with-suppressed-warnings ((obsolete define-child-mode))
      ;; FIXME: We should handle this some other way!
      (define-child-mode lisp-mode emacs-lisp-mode
        "Make `lisp-mode' inherit mode local behavior from `emacs-lisp-mode'."))

Any idea why the `with-suppressed-warnings` doesn't actually suppress
the warning?  Any hope you could fix it?


        Stefan

Re: with-suppressed-warnings ineffective?

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Any idea why the `with-suppressed-warnings` doesn't actually suppress
> the warning?  Any hope you could fix it?

In the macro case, the symbol wasn't passed on to
byte-compile-warning-enabled-p.  I've now fixed this on the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: with-suppressed-warnings ineffective?

[Stefan Monnier]

>> Any idea why the `with-suppressed-warnings` doesn't actually suppress
>> the warning?  Any hope you could fix it?
> In the macro case, the symbol wasn't passed on to
> byte-compile-warning-enabled-p.

Duh!  I can't believe I missed this detail!!

> I've now fixed this on the trunk.

Thanks!!!


        Stefan!!!!