From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 34765@debbugs.gnu.org, larsi@gnus.org, alexanderm@web.de
Subject: bug#34765: 26.1; with-temp-buffer should not run buffer-list-update-hook
Date: Fri, 18 Dec 2020 10:36:22 -0500 [thread overview]
Message-ID: <jwvwnxfruwy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <878sa9cle0.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 07 Dec 2020 22:16:23 +0000")
> (defmacro with-temp-file (file &rest body)
> "Create a new buffer, evaluate BODY there, and write the buffer to FILE.
> The value returned is the value of the last form in BODY.
> -See also `with-temp-buffer'."
> +The buffer is created using `with-temp-buffer', which see."
> (declare (indent 1) (debug t))
> - (let ((temp-file (make-symbol "temp-file"))
> - (temp-buffer (make-symbol "temp-buffer")))
> - `(let ((,temp-file ,file)
> - (,temp-buffer (generate-new-buffer " *temp file*")))
> - (unwind-protect
> - (prog1
> - (with-current-buffer ,temp-buffer
> - ,@body)
> - (with-current-buffer ,temp-buffer
> - (write-region nil nil ,temp-file nil 0)))
> - (and (buffer-name ,temp-buffer)
> - (kill-buffer ,temp-buffer))))))
> + `(with-temp-buffer
> + (prog1 (progn ,@body)
> + (write-region nil nil ,file nil 0))))
You lost the `(with-current-buffer ,temp-buffer` around `write-region`
so your new code will break if `body` doesn't preserve current-buffer.
Stefan
next prev parent reply other threads:[~2020-12-18 15:36 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 22:57 bug#34765: 26.1; with-temp-buffer should not run buffer-list-update-hook Alexander Miller
2019-03-06 9:39 ` martin rudalics
2019-03-06 11:29 ` Alexander Miller
2019-03-06 14:13 ` martin rudalics
2019-03-06 15:41 ` Eli Zaretskii
2019-03-06 17:57 ` martin rudalics
2019-04-23 9:21 ` martin rudalics
2019-04-23 10:36 ` Eli Zaretskii
2019-04-24 7:27 ` martin rudalics
2019-04-24 11:12 ` Eli Zaretskii
2019-04-24 12:55 ` Stefan Monnier
2019-04-25 8:06 ` martin rudalics
2019-04-25 8:50 ` Eli Zaretskii
2019-04-25 10:31 ` martin rudalics
2019-04-25 10:49 ` Eli Zaretskii
2019-04-26 7:40 ` martin rudalics
2019-04-26 8:09 ` Eli Zaretskii
2019-04-25 13:01 ` Stefan Monnier
2019-04-25 14:34 ` Eli Zaretskii
2019-04-26 7:41 ` martin rudalics
2019-04-26 8:10 ` Eli Zaretskii
2019-04-26 7:41 ` martin rudalics
2019-04-26 8:10 ` Eli Zaretskii
2019-04-26 11:00 ` martin rudalics
2019-04-26 11:26 ` Eli Zaretskii
2019-04-27 8:30 ` martin rudalics
2019-04-26 17:14 ` Basil L. Contovounesios
2019-04-27 8:31 ` martin rudalics
2019-05-20 13:42 ` Basil L. Contovounesios
2019-05-21 7:32 ` martin rudalics
2019-05-21 7:58 ` Basil L. Contovounesios
2019-05-21 10:04 ` martin rudalics
2019-05-22 7:29 ` Eli Zaretskii
2019-05-22 8:32 ` martin rudalics
2019-05-22 10:06 ` Eli Zaretskii
2019-05-23 8:38 ` martin rudalics
2019-05-23 14:37 ` Eli Zaretskii
2019-05-24 8:01 ` martin rudalics
2019-05-22 14:12 ` Stefan Monnier
2019-05-22 15:50 ` Eli Zaretskii
2019-05-22 7:21 ` Eli Zaretskii
2020-08-26 11:06 ` Lars Ingebrigtsen
2020-09-05 7:05 ` Eli Zaretskii
2020-10-07 3:27 ` Lars Ingebrigtsen
2020-10-07 7:58 ` martin rudalics
2020-11-29 21:03 ` Basil L. Contovounesios
2020-11-30 9:05 ` martin rudalics
2020-11-30 18:07 ` Basil L. Contovounesios
2020-11-30 19:01 ` martin rudalics
2020-11-30 20:33 ` Basil L. Contovounesios
2020-12-01 9:34 ` martin rudalics
2020-11-30 19:42 ` Eli Zaretskii
2020-11-30 20:34 ` Basil L. Contovounesios
2020-12-07 22:16 ` Basil L. Contovounesios
2020-12-07 22:37 ` Basil L. Contovounesios
2020-12-08 8:09 ` martin rudalics
2020-12-14 21:03 ` Basil L. Contovounesios
2020-12-15 16:03 ` Eli Zaretskii
2020-12-15 16:24 ` Basil L. Contovounesios
2020-12-18 14:57 ` Basil L. Contovounesios
2020-12-18 15:36 ` Stefan Monnier [this message]
2020-12-18 18:49 ` Basil L. Contovounesios
2020-12-19 10:33 ` Eli Zaretskii
2020-12-19 14:15 ` Basil L. Contovounesios
2020-12-19 16:06 ` Eli Zaretskii
2020-12-19 21:10 ` Basil L. Contovounesios
2020-12-20 15:05 ` Eli Zaretskii
2019-03-07 6:18 ` Alexander Miller
2019-03-07 8:29 ` martin rudalics
2019-03-07 9:44 ` Alexander Miller
2019-03-07 13:46 ` martin rudalics
2020-12-20 17:57 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwnxfruwy.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=34765@debbugs.gnu.org \
--cc=alexanderm@web.de \
--cc=contovob@tcd.ie \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.