From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Matt Armstrong <matt@rfc20.org>
Cc: 46819@debbugs.gnu.org
Subject: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation
Date: Sat, 27 Feb 2021 16:00:21 -0500 [thread overview]
Message-ID: <jwvwnut5ixb.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m2eeh1uuvj.fsf@matts-mbp-2016.lan> (Matt Armstrong's message of "Sat, 27 Feb 2021 12:18:56 -0800")
> This behavior began with Stefan's recent commit d41a4ad4ae (*
> lisp/emacs-lisp/macroexp.el ;; (macroexp--expand-all): Warn on empty let
> bodies, 2021-02-15)
>
> `benchmark-run' has a timing `doloop' with an empty body, which `doloop`
> expands to a `let` with an empty body (in the lexical-binding case).
It'd be easy to put an explicit nil in the loop's body, but....
The idea was that in actual (non-macroexpanded) source code, empty let
bodies are usually the result of a misplaced paren. But it's probably
more often annoying than useful since we can't easily distinguish a "let
from source code" from a "let from a macro expansion".
So I'm also voting to revert that change.
Any objection?
Stefan
next prev parent reply other threads:[~2021-02-27 21:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 20:18 bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation Matt Armstrong
2021-02-27 21:00 ` Stefan Monnier [this message]
2021-02-28 14:13 ` Lars Ingebrigtsen
2021-03-01 0:04 ` Matt Armstrong
2021-03-01 0:09 ` Lars Ingebrigtsen
2021-03-01 0:19 ` Lars Ingebrigtsen
2021-03-01 5:04 ` Stefan Monnier
2021-03-02 5:07 ` Matt Armstrong
2021-03-10 4:53 ` Matt Armstrong
2021-03-10 14:54 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwnut5ixb.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=46819@debbugs.gnu.org \
--cc=matt@rfc20.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.