From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] scratch/email-revision-details da3795b 1/2: * elpa-admin.el (elpaa--get-release-revision): Workaround git bug Date: Fri, 06 Aug 2021 11:30:10 -0400 Message-ID: References: <20210806151651.16524.53159@vcs0.savannah.gnu.org> <20210806151653.0F131203E8@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31433"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Phil Sainty To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 06 17:31:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mC1oY-000804-Df for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Aug 2021 17:31:14 +0200 Original-Received: from localhost ([::1]:58930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mC1oX-00025T-4F for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Aug 2021 11:31:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC1ng-0001I5-MM for emacs-devel@gnu.org; Fri, 06 Aug 2021 11:30:20 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57783) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC1nb-0005cf-RV for emacs-devel@gnu.org; Fri, 06 Aug 2021 11:30:19 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CBC4D80925; Fri, 6 Aug 2021 11:30:12 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 66A7980323; Fri, 6 Aug 2021 11:30:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1628263811; bh=YkBcFTY+tfRYZP97eDKnIFPRur9cubFkR88TdspZtYA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XL4soLG/sJwcGwRXn2xG6Sez0EvtwGBD0T66KZx88/X+QvWeeTi4kJ1+BPCiIoTDR upCszI3MSfIM2n5TbCx7qotNhhJAoTrvSFhAsj/POi5RUl6ve75IYhRxEZOuvH6PDj BnEHBmyLFhcm1SrWJYwz3HVIPErR8jPtrJeDTexytf64N4sn/6wuMWk6R69UQcF+W7 prPr3WWLa5tfdg8U0i5anbpYYhslYpXwaTMny8fzLsxiOkfwky8NVNxthPH7AAhd46 rznLJtI+cf11wgnFqLLlHHFIt4UNHQlz4A4UzB1yfB+QWvsdcZTwzx7vk/laoHHn3d i1OU75a5cCPNQ== Original-Received: from alfajor (unknown [216.154.29.138]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2A45312023C; Fri, 6 Aug 2021 11:30:11 -0400 (EDT) In-Reply-To: <20210806151653.0F131203E8@vcs0.savannah.gnu.org> (Phil Sainty's message of "Fri, 6 Aug 2021 11:16:52 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272142 Archived-At: > diff --git a/elpa-admin.el b/elpa-admin.el > index e26108b..fa01001 100644 > --- a/elpa-admin.el > +++ b/elpa-admin.el > @@ -184,7 +184,11 @@ commit which modified the \"Version:\" pseudo header." > "--pretty=format:%H" > "-L" (concat "/^;;* *\\(Package-\\)\\?Version:/,+1:" > (file-name-nondirectory mainfile)))) > - (buffer-string) > + ;; The --no-patch (aka -s) option does not work > + ;; with "git log -L,:" before git > + ;; version 2.22; so capture only the first line. > + (buffer-substring-no-properties > + (goto-char (point-min)) (line-end-position)) > (cons 'error (buffer-string)))))) > (if (stringp release-rev) > (progn Feel free to push this to `master`, it looks good to me. Stefan