From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp Date: Sat, 12 Feb 2022 15:32:16 -0500 Message-ID: References: <164464970577.18616.16858189491672331595@vcs2.savannah.gnu.org> <20220212070826.4B772C00895@vcs2.savannah.gnu.org> <83y22frjpy.fsf@gnu.org> <83tud3ri2n.fsf@gnu.org> <83r187rhd8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37240"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 12 21:34:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIz5q-0009RD-Mm for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Feb 2022 21:34:06 +0100 Original-Received: from localhost ([::1]:57210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIz5p-0004Xz-60 for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Feb 2022 15:34:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIz4C-0003qw-K6 for emacs-devel@gnu.org; Sat, 12 Feb 2022 15:32:24 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39939) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIz4A-0004AV-0O; Sat, 12 Feb 2022 15:32:23 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6BCEC100211; Sat, 12 Feb 2022 15:32:20 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D386B100124; Sat, 12 Feb 2022 15:32:18 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1644697938; bh=UmDpCPnA7eyv/rD5r3b/xdgnLPAdgUGCTWooXXxp054=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aNHoBzFOazJGN8lU1hZnnZDervEx/40GlFd75i/HBgs8VLRsqVaOVjmVkMv+g6eiT C8ZAcfGsAazS2jkToi1+r6ywldp8lfZtYqXQGjqDfkd8Mk8AGHVt3jWyZiSIeLzN3J g4/WP+r2yFfNmU+PNE1Eyv8mToKQ2gJfyV/Zdj0U1SHx4CfRuk+5YqOB4Zlhyo0C1a kASFaqLRsjAzIFTfIlH30hdb0D/nILpFEVt9chQAjtg4r7dkkrsf/Ahr2wBo5FkM5K uHtPyFJGC9lE+7aSYm3VR+XaSPYZb/lOZhyRytaP5/BwzszgQoOsgN7mClY6rl8fov ZwdrkbqNfnBNg== Original-Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6B1B3120813; Sat, 12 Feb 2022 15:32:18 -0500 (EST) In-Reply-To: <83r187rhd8.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Feb 2022 21:53:55 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286197 Archived-At: >> >> I know. And I'm asking why `file-size-human-readable` gives so >> >> much accuracy. >> > >> > It's a feature: >> > >> > (format (if (and (>= (mod file-size 1.0) 0.05) >> > (< (mod file-size 1.0) 0.95)) >> > "%.1f%s%s" >> > "%.0f%s%s") >> >> Why is it a feature > > It's a feature by definition: there's code that intentionally does > that. > >> to waste those two perfect good characters on such irrelevant >> details? > > A feature doesn't have to be liked to be a feature. No, but if we don't like it we can remove it. Do you find this feature useful? If so, can you give me an idea what you like about it? Stefan