From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#6892: Please add a way to jump to advices Date: Mon, 09 May 2022 12:50:22 -0400 Message-ID: References: <87zgjq3bfz.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7116"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Ken Hori , 6892@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 09 18:51:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no6bR-0001bC-DS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 18:51:21 +0200 Original-Received: from localhost ([::1]:55972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no6bP-00038h-LV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 12:51:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no6b8-00037D-Ul for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 12:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37170) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no6b8-0002xY-HV for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 12:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no6b8-0002Jx-Cy for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 12:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2022 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6892 X-GNU-PR-Package: emacs Original-Received: via spool by 6892-submit@debbugs.gnu.org id=B6892.16521150408887 (code B ref 6892); Mon, 09 May 2022 16:51:02 +0000 Original-Received: (at 6892) by debbugs.gnu.org; 9 May 2022 16:50:40 +0000 Original-Received: from localhost ([127.0.0.1]:59300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no6am-0002JH-0N for submit@debbugs.gnu.org; Mon, 09 May 2022 12:50:40 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no6ag-0002Iw-Q6 for 6892@debbugs.gnu.org; Mon, 09 May 2022 12:50:38 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0C1DE440C8B; Mon, 9 May 2022 12:50:29 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B41D6440BA0; Mon, 9 May 2022 12:50:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1652115027; bh=LV+rWupvnHwWIx+Qs0FEoGpVZp7MetcSmwEayAMVBe0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=E0nb2gC3Wgh5XlbEHy4OH6LxNTqvRs5RY2z/xx14iIyWbOT+nc/l/blF4preigWgc 70AFZAihWiAYsnm2G58caoHEgbUX8OcV3IlCpJ4b9tp3IX4nFi93CpjCYIogTGhk8g 0y/lnkskOL80fNB5+GmQ6gPukM9lI6W+Kuf0PKzPtulfx1LAQWmOC6LrQRrT30LX2f njh4aJ/LSWoxgkQOzhj3Dp2yJkMumi4gyLjnSAhp0XKjjgu8ZrOxNFWSxxPLYxQjKk K4vtRU4jkZhNTgs7rhGfu9VwwmjTz6D3zQIYDlibYf8QKY0YMNGEPbbudY5a02abZc 7+XZ+6TMmyNWw== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 819AE120255; Mon, 9 May 2022 12:50:27 -0400 (EDT) In-Reply-To: <87zgjq3bfz.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 09 May 2022 18:41:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231767 Archived-At: > (I'm going through old bug reports that unfortunately weren't resolved > at the time.) > > This seems to still be the case with advice-add: > > (defun bar () > (interactive) > (forward-line 1)) > > (advice-add 'bar :before (lambda () (forward-line 1))) But it should work if you do (advice-add 'bar :before #'bar--skip-line) (defun bar--skip-line () (forward-line 1)) > I'm sure this has come up before -- does advice add no pointers (to > load-history, I guess?) that the help system could pick up? `define-advice` could, but `advice-add` is definitely not limited to uses at top-level, so it shouldn't mess with `load-history`. Stefan