From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Splitting some erc tests Date: Tue, 24 May 2022 22:17:37 -0400 Message-ID: References: <87wneag2zc.fsf@gnus.org> <87bkvmfm8b.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23446"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "emacs-devel@gnu.org" To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 25 04:18:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntgbZ-0005qr-I0 for ged-emacs-devel@m.gmane-mx.org; Wed, 25 May 2022 04:18:33 +0200 Original-Received: from localhost ([::1]:56338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntgbX-0000xv-TS for ged-emacs-devel@m.gmane-mx.org; Tue, 24 May 2022 22:18:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntgao-0000FY-DK for emacs-devel@gnu.org; Tue, 24 May 2022 22:17:46 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64327) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntgal-0006yA-I4 for emacs-devel@gnu.org; Tue, 24 May 2022 22:17:44 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 676D91001CB; Tue, 24 May 2022 22:17:41 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8A8A1100091; Tue, 24 May 2022 22:17:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1653445059; bh=vICDfA37jrOSB7ZItxBjPtLehBlD4r2FO9/Fi/m+iWM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BAq+8AI7jkKGWWGMY0JNB72UEToPCPHUwCyCxDVJ2QVcn2y6ijJQH6KrTbEf/AvxS vVNL0viQdlmGutgqbWmIjkC4Cd6AikQJf5lIra1Ik0oADGa0c3lwOppTu0M6rCqmuu Qfhbypk6Qa1xXApWHidTRef7t0F/O0mMWe98grCsOWyzyf6Px2+z+NlIfi9nL0ljiV cEbfKJnnVbTCHxDdJE339Qt7jnuFgMiR4KLXxJ61DfWAMbNickx6PngwaD2d4pU5LP kaG5mZFUomBWXwSNdG74CXLTOTnLiuZOtiCsxrnf3QfTLKkE523pxHuu9h5nRqf5H/ LjGZUUtNjLxyw== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5891E1202AF; Tue, 24 May 2022 22:17:39 -0400 (EDT) In-Reply-To: <87bkvmfm8b.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 25 May 2022 03:13:24 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290228 Archived-At: > but that goes against the Make grain -- Make should control the > parallelism, of course. So a number of rules like: > > %.log-1: %.elc > $(emacs) ... (ert-run-tests-batch-and-exit ... $* $jobs) > > or something... but... this is way out of my Makefile comfort zone. Something like that, yes. My intuition tells me to first give those tests some unique name pattern, so that we can use a different rule like %-par2.log: %-par2.elc %-2.1-part.log %-2.2-part.log cat $*-2.1-part.log $*-2.2-part.log >$@ Generalizing this to `%-parN.log` and writing the rules for `%-N.M-part.log` is left as an exercise for the reader. BTW I don't think we need to know the `-j` arg passed to `make` to decide how to split the files: just split them into coarse enough grains that splitting them doesn't slow down the -j1 case significantly. Stefan