From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56469: 29.0.50; Unibyte dir in directory_files_internal Date: Sat, 09 Jul 2022 14:20:37 -0400 Message-ID: References: <83y1x2177x.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15989"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56469@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 09 20:21:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAF4u-0003uG-VE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Jul 2022 20:21:17 +0200 Original-Received: from localhost ([::1]:45286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAF4t-0000ye-R7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Jul 2022 14:21:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAF4h-0000yI-M9 for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2022 14:21:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAF4g-0001kD-LT for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2022 14:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oAF4g-00012u-Gj for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2022 14:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jul 2022 18:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56469 X-GNU-PR-Package: emacs Original-Received: via spool by 56469-submit@debbugs.gnu.org id=B56469.16573908523984 (code B ref 56469); Sat, 09 Jul 2022 18:21:02 +0000 Original-Received: (at 56469) by debbugs.gnu.org; 9 Jul 2022 18:20:52 +0000 Original-Received: from localhost ([127.0.0.1]:35901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAF4V-00012C-MD for submit@debbugs.gnu.org; Sat, 09 Jul 2022 14:20:51 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAF4T-00011y-AB for 56469@debbugs.gnu.org; Sat, 09 Jul 2022 14:20:49 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EA5444406EF; Sat, 9 Jul 2022 14:20:43 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 98D03440762; Sat, 9 Jul 2022 14:20:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1657390838; bh=XD5aSCaObo70++FnvX5uHwFuu6CyBOnVW6l9GZOxrXE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hljd+cqVbMXs6iYvcMXRiZnSLHYvvYZmp0tVJbQ2iqyrsKUsgqeRsBkjwtSOYCtCG lgf39XZNoijNgjwgdAT2GU0r1qh06TzHzFEq7sb5Lf3/PGFW+rXuHq7tQjbK/n9DVC GC9tNAMS8NYo6Fy3DTfX2zxXQ1FZoj9VCy6bFQ/KRnyRReOvzyEHzuzyc8Ej1BNPRN ByuaM8r5LfcEaYDGDgVrR47z7jCbB5U0zKrdu0R+a5/SLMzfCUoeDbe+dnExbrz198 jkPS0aXCuFQAFb984eqCdXwJ0WBuQ3ZAngrgP2Ht25W6MaH5g9r0gooNnbyD0WDUzq 5J2Hhw/E1J4gQ== Original-Received: from pastel (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6C192120192; Sat, 9 Jul 2022 14:20:38 -0400 (EDT) In-Reply-To: <83y1x2177x.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Jul 2022 21:17:22 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236531 Archived-At: >> I suggest the patch below. In a comment I suggest we don't try to use >> unibyte strings when a multibyte string would work as well. This is >> because for those ASCII-only strings, it's cheaper to test bytes==chars >> to (re)discover that they are ASCII-only (when they're multibyte) than >> having to loop through the bytes (when they're unibyte). > > Please bootstrap Emacs in a directory with such a name, and if that > works, I'm okay with installing this change. Just to clarify: by "this change" you refer to the change in the patch or the change suggested in the comment? Stefan