From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: <miha@kamnitnik.top>
Cc: 58169@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>,
Augusto Stoffel <arstoffel@gmail.com>,
Visuwesh <visuweshm@gmail.com>
Subject: bug#58169: 29.0.50; comint-fl-mode fontifies the output
Date: Sat, 01 Oct 2022 10:43:09 -0400 [thread overview]
Message-ID: <jwvwn9jk3sv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87leq0u0p8.fsf@miha-pc> (miha@kamnitnik.top's message of "Fri, 30 Sep 2022 21:22:27 +0200")
> @@ -2150,24 +2150,26 @@ comint-output-filter
> ;; insert-before-markers is a bad thing. XXX
> ;; Luckily we don't have to use it any more, we use
> ;; window-point-insertion-type instead.
> - (insert string)
> + (make-local-variable 'jit-lock-mode)
> + (let ((jit-lock-mode nil))
> + (insert string)
Yuck!
Oh, and this will fail to do what it intends if the user has set
`font-lock-support-mode` t nil: don't confuse font-lock and jit-lock.
Also, I suspect that the above is not sufficient if you edit earlier
parts of the buffer (presumably previous inputs) which may cause later
parts to be *re*fontified.
A better way might be to change the font-lock rules to skip any text
that is marked as being output (e.g. by testing if the `field` property
is set to `output`).
Stefan
next prev parent reply other threads:[~2022-10-01 14:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 16:24 bug#58169: 29.0.50; comint-fl-mode fontifies the output Augusto Stoffel
2022-09-30 1:55 ` Visuwesh
2022-09-30 5:58 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-30 13:38 ` Lars Ingebrigtsen
2022-09-30 18:38 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-30 18:26 ` Lars Ingebrigtsen
2022-09-30 19:22 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-30 19:14 ` Lars Ingebrigtsen
2022-10-01 14:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-10-06 18:37 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwn9jk3sv.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=58169@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=larsi@gnus.org \
--cc=miha@kamnitnik.top \
--cc=monnier@iro.umontreal.ca \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.