From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master c69858b3f0: ; * lisp/treesit.el (treesit-ready-p): Guard against empty buffers. Date: Tue, 22 Nov 2022 20:51:40 -0500 Message-ID: References: <166916717199.12853.3816069320355351676@vcs2.savannah.gnu.org> <20221123013252.46814C004B6@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11157"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Yuan Fu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 23 02:52:13 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxevt-0002gu-7F for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Nov 2022 02:52:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxevU-0007mN-DI; Tue, 22 Nov 2022 20:51:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxevR-0007m8-Ve for emacs-devel@gnu.org; Tue, 22 Nov 2022 20:51:46 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxevQ-0008NX-GA for emacs-devel@gnu.org; Tue, 22 Nov 2022 20:51:45 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 00E2E1000ED; Tue, 22 Nov 2022 20:51:43 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5FFCA10002F; Tue, 22 Nov 2022 20:51:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1669168301; bh=jzQ/ZCdwGI3V3VPiaEDQvv9vy0bxXa7SXCNW6sm6J/g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KSrESVaqGZ9bxf+Zf1O2nAg1PP1Qmw3AcpEt7QMUpG9LT16CFlbWyS4t9pbFeN3cV Ntd0zVCCfSKL8NnGumaK3vaSV6zXpRVNMqf9ZMGRiSkqtzXka7G0C/eSzNklgsUbq4 Ln4jSgkOoeNGZVJn70QB3cSTv/uRk36SOTzg9I6q88g3uCvfMz/roU3x+E6rDzxBUg D3gcYb8N668DUc24t2NoTaEAUM53uVknbJdmHDYKKlDf9KRnNacDAjYts4y5kv34OE gdN4Ypaje9D8480kxKCscJq3pyU7SelPf4R+HOHRjEivZPe/M1/QLs0pGgx3jUJM9o z4X+A56UUpc+g== Original-Received: from pastel (unknown [104.247.241.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3CC9412043F; Tue, 22 Nov 2022 20:51:41 -0500 (EST) In-Reply-To: <20221123013252.46814C004B6@vcs2.savannah.gnu.org> (Yuan Fu's message of "Tue, 22 Nov 2022 20:32:52 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300368 Archived-At: > - (when (> (position-bytes (1- (point-max))) treesit-max-buffer-size) > + (when (> (position-bytes (max (point-min) (1- (point-max)))) > + treesit-max-buffer-size) I'd expect `treesit-max-buffer-size` to be compared to `buffer-size` rather than to buffer positions. Is it really that important to count bytes rather than characters? Stefan