From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Plug treesit.el into other emacs constructs Date: Mon, 12 Dec 2022 10:46:17 -0500 Message-ID: References: <87wn6whete.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15061"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, eliz@gnu.org, casouri@gmail.com To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 12 16:46:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4l16-0003f7-Lu for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Dec 2022 16:46:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4l0u-0007uB-AT; Mon, 12 Dec 2022 10:46:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4l0b-0007mA-CR for emacs-devel@gnu.org; Mon, 12 Dec 2022 10:46:29 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4l0Z-0000M5-30; Mon, 12 Dec 2022 10:46:24 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D14531000FF; Mon, 12 Dec 2022 10:46:20 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6545D1000D5; Mon, 12 Dec 2022 10:46:19 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670859979; bh=SzZSAFYhNGFhT3ri+okkoZe5e2caKKjjdwfHT9SLO3s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GOE5K0xVGlu2XApEQHjOeY4mBVG57egJEXssfjowGMCNwdbxPTyN2fFoMvJmtbRvY LoagL4E8h5SViiOQOemzcPBQLNA/iFwKplpItcv/Bieemz5Asw8vgRGULwktvPW5KN hbrxdvNDD/t6e6MLVNJWze2OosHmTbmXF4ZOi00oEPAqXt7XVBNJ+XNR5y9YPC5Zev fnlrGdmbXiP9Hql85/wLudX784YtDsR/sonvgD+M3Z+BAhc5m7dDNB6scerMR5luxL Mnm5D9U8NJMggBgIKIb8E3P3A5GcE75pJRwvVgLdhGRELLs1ikRwG4fIUtU63uE/+7 EeO+lGD8TUX2w== Original-Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2C578120E5B; Mon, 12 Dec 2022 10:46:19 -0500 (EST) In-Reply-To: <87wn6whete.fsf@thornhill.no> (Theodor Thornhill's message of "Mon, 12 Dec 2022 15:33:33 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301246 Archived-At: Cool, thanks, a few comments (based on my experience with adding similar things based on `smie`): > ** Forward-sexp: > Executing C-M-f repeatedly will go from: > ``` > public void foo(|String bar, String baz) {} > ``` > to > ``` > public void foo(String bar|, String baz) {} > ``` That looks wrong. `String` is a valid AST node. Whether it gets a node in tree-sitter or not, I don't know, but here there are several "sexps" that start at point and I think `forward-sexp` should be conservative and keep advancing by the smallest option. There can be many more than 2 choices, of course, e.g.: x = |f (x) * 3 + 2; Here "f" is the smallest sexp after point, "f (x)" is the next one up, then "f (x) * 3" and finally "f (x) * 3 + 2". > ``` > public void foo(String bar, String baz|) {} > ``` That one's right :-) > ** transpose-sexp: > Executing C-M-t repeatedly will go from: > ``` > public void foo(int bar,| String baz) {} > ``` > to > ``` > public void foo(String baz, int bar|) {} > ``` And this one it right as well (regardless if | starts after or before the comma). Does it work as well for infix keywords that are made of normal letters, like say `else` (or the `and` and `or` used in some languages instead of `&&` and `||`)? Stefan