From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package xeft.el Date: Wed, 04 Jan 2023 14:24:58 -0500 Message-ID: References: <64A01ADD-E757-40F5-A5C3-518BB8BE9A41@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 04 20:25:36 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pD9OK-00051Y-F7 for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Jan 2023 20:25:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pD9Nw-00020g-Sb; Wed, 04 Jan 2023 14:25:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD9Nv-00020Y-Rs for emacs-devel@gnu.org; Wed, 04 Jan 2023 14:25:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD9Nu-0004iR-0p for emacs-devel@gnu.org; Wed, 04 Jan 2023 14:25:11 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 235988056A; Wed, 4 Jan 2023 14:25:08 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 07BE3801E0; Wed, 4 Jan 2023 14:25:06 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1672860306; bh=1nghlOwdKtLajpnpQuteerC0TiRpC9gkRXWb0PgZmOE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NWvwO5pXqVPHpag6JCVz8nXkd6Riuy3ukIN3d9p47gOFUAJb7xnqQ8Nap1W3s8G8n XiPMuzMEYsLhr9j98RP6bNoJ+HWotZz/1ZlezhBVG2CMYMcjy9Zp0CqscunlKhLb42 HZc+wfQivJzQxFQvLAYBDYZuSR+LRvGIug0iSLVswj9TC2lCBhP2hQefinyjsIJ2aJ bCtJ5+cZ0DGP1j9UhnCdbtWrb/CGFvGsXhmXhlhEWuZ88ko1mMqbwOxeDd4I+FlSuM LaRUZ/KDgpmoCcHj35iH4jUqPOmy29QagLlyrR5NGLgVKPa3wnc1PYaLEeHVs2ZgaF ARBdDWSXlCNOA== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AC8D01202DB; Wed, 4 Jan 2023 14:25:05 -0500 (EST) In-Reply-To: <64A01ADD-E757-40F5-A5C3-518BB8BE9A41@gmail.com> (Yuan Fu's message of "Mon, 2 Jan 2023 20:11:50 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302231 Archived-At: Yuan Fu [2023-01-02 20:11:50] wrote: > I wrote xeft.el awhile ago, it allows you to search text notes really fast > by using a dynamic module. My initial plan is to somehow plug the dynamic > module into Deft some day and I=E2=80=99ll keep xeft to myself. Turns out= it=E2=80=99s not > very feasible to make Deft use the dynamic module, so now I thought I mig= ht > as well publish xeft. After all I think it is really cool and I want more > people to use it :-) > > You can find xeft here: https://git.sr.ht/~casouri/xeft I'm a bit uncomfortable with the way this is set up: it's unusable without downloading further code first. Why not do it like the `pq` package, which includes the C source code in the GNU ELPA package? IOW merge your `xapian-lite` repository into the `xeft` repository. Or make a GNU ELPA package for `xapian-lite` if you think the two should not be so closely tied to one another? Other details I saw along the way: - You claim you have precompiled packages for GNU/Linux but that's only true for amd64, which is only a particular subset of GNU/Linux (most of my GNU/Linux machines (i386, armhf, arm64) are outside of that subset, for example). - Your source code includes `emacs-module.h` which should not be necessary because that file is distributed with Emacs (the way `pq` finds it is not ideal, but this might be a good opportunity to look at improving the situation and providing a standardized way for ELisp packages to find that file). - `xapian-lite.cc` lacks a license blurb. Stefan