From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60333: [PATCH] whitespace: Update bob, eob markers in base and indirect buffers Date: Thu, 12 Jan 2023 11:15:00 -0500 Message-ID: References: <819d60c0-af5d-6936-d7ed-dc8a898adb3c@rhansen.org> <83h6wwksii.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35316"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60333@debbugs.gnu.org, Richard Hansen To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 12 17:16:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pG0FX-0008zZ-7s for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Jan 2023 17:16:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pG0FJ-0003P0-V0; Thu, 12 Jan 2023 11:16:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pG0FI-0003Ob-Ft for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 11:16:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pG0FG-00050U-I8 for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 11:16:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pG0FF-0000Qf-RN for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 11:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Jan 2023 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60333-submit@debbugs.gnu.org id=B60333.16735401141584 (code B ref 60333); Thu, 12 Jan 2023 16:16:01 +0000 Original-Received: (at 60333) by debbugs.gnu.org; 12 Jan 2023 16:15:14 +0000 Original-Received: from localhost ([127.0.0.1]:48422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG0EU-0000PU-3V for submit@debbugs.gnu.org; Thu, 12 Jan 2023 11:15:14 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:5216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG0ES-0000PD-EU for 60333@debbugs.gnu.org; Thu, 12 Jan 2023 11:15:12 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AA16944160A; Thu, 12 Jan 2023 11:15:06 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F246C440A0E; Thu, 12 Jan 2023 11:15:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1673540105; bh=CF2mvJzveTun/gYHlKYgaQU4WFtUTVsFrxCTcN93Zb8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KpnTbPcQjhbH6+exTsrkpGHM3igya34Ydaeg8EnwSf+1HXE5fysJQXDjUAm9rdYmi rbGFz4gbRlyUQ5rail80cpJe5seteGBF2oAMRLOE2D3p5NjKTV36fo/tivXIMQZodt 1NyyNpKn6wHo/xjpDZoKBiDIQevpNwFmQX6IlyoYWl1liIB/8w4EyA5s07hOcJpJoC YaYuchZOGB8/K6g2cdvLBG+ao4Mxdr2NscsOF7ZCoTr5rTK2KI3efkgE00cSLyLbmS 6gFVlfNCuCaRhCC1LmUUT7DEeOrdTllOEHGQVBzvftZFj3se9epC/EeUFTxdGmvDar FtnqpQXRBgRxA== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D0A5F120A92; Thu, 12 Jan 2023 11:15:04 -0500 (EST) In-Reply-To: <83h6wwksii.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 12 Jan 2023 11:32:21 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253231 Archived-At: >> On 12/28/22 09:51, Stefan Monnier wrote: >> >> When a buffer is changed, update `whitespace-bob-marker' and >> >> `whitespace-eob-marker' not just in the current buffer, but >> >> also in the base buffer and all of its indirect buffers (if >> >> any) (Bug#46982). >> > >> > That doesn't sound right. We should only update them in those indirect buffers >> > which also use whitespace eob/bob markers. It should be their individual >> > responsibility to register hook functions to update their own markers. >> >> The changelog was worded poorly; it does what you expect it to do. >> Attached is an updated patch with hopefully better wording; please let >> me know if it still needs improvement. > > Stefan, any further comments, or should this go in? I think it shouldn't because it fixes a corner case of a much wider problem. E.g.: emacs -Q lisp/subr.el M-x make-indirect-buffer RET RET foo RET C-x 2 C-x b foo RET C-d C-d C-d You should now see the first line of `subr.el` as: subr.el --- basic lisp subroutines for Emacs -*- lexical-binding:t -*- yet still highlighted as a comment because the buffer modification (and hence the `after-change-functions`) was performed in the indirect buffer which is in `fundamental-mode` and doesn't know it should mark the line for re-fontification. Stefan